Always use case-insensitive fs operartions for RWC #18046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
approved these changes
Aug 25, 2017
src/harness/rwcRunner.ts
Outdated
| @@ -79,7 +79,7 @@ namespace RWC { | |||
| tsconfigFiles.push({ unitName: tsconfigFile.path, content: tsconfigFileContents.content }); | |||
| const parsedTsconfigFileContents = ts.parseJsonText(tsconfigFile.path, tsconfigFileContents.content); | |||
| const configParseHost: ts.ParseConfigHost = { | |||
| useCaseSensitiveFileNames: Harness.IO.useCaseSensitiveFileNames(), | |||
There was a problem hiding this comment.
It seems like this is something we need to capture and read from the rwc capture file.
There was a problem hiding this comment.
And now it does. No captures should need to be updated, since undefined is coercible to false, and they all execute correctly under case insensitivity as it currently stands.
sandersn
approved these changes
Aug 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sandersn Noted that on linux many RWC tests fail due to using the system case-sensitivity, rather than the sensitivity used when capturing the test. For now, we just assume all tests were captured on a case-insensitive file system, which should allow our linux developers to run the tests without spurious failures.