Skip to content

Add exported members of all project files in the global completion list #17851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
d99675b
checker.ts: Remove null check on symbols
minestarks Aug 10, 2017
5bef866
tsserverProjectSystem.ts: add two tests
minestarks Aug 10, 2017
087de79
client.ts, completions.ts, types.ts: Add codeActions member to Comple…
minestarks Aug 10, 2017
a84b5b5
protocol.ts, session.ts: Add codeActions member to CompletionEntryDet…
minestarks Aug 10, 2017
15b73d0
protocol.ts, session.ts, types.ts: add hasAction to CompletionEntry
minestarks Aug 10, 2017
8a1a124
session.ts, services.ts, types.ts: Add formattingOptions parameter to…
minestarks Aug 10, 2017
0aa865f
completions.ts: define SymbolOriginInfo type
minestarks Aug 10, 2017
25831a8
completions.ts, services.ts: Add allSourceFiles parameter to getCompl…
minestarks Aug 10, 2017
9940c92
completions.ts, services.ts: Plumb allSourceFiles into new function g…
minestarks Aug 10, 2017
c838093
completions.ts: add symbolToOriginInfoMap parameter to getCompletionE…
minestarks Aug 10, 2017
c5cc2f1
utilities.ts: Add getOtherModuleSymbols, getUniqueSymbolIdAsString, g…
minestarks Aug 10, 2017
b024285
completions.ts: Set CompletionEntry.hasAction when symbol is found in…
minestarks Aug 10, 2017
041302f
completions.ts: Populate list with possible exports (implement getSym…
minestarks Aug 10, 2017
abe1fdb
completions.ts, services.ts: Plumb host and rulesProvider into getCom…
minestarks Aug 10, 2017
ae0ab47
completions.ts: Add TODO comment
minestarks Aug 10, 2017
95a9c01
importFixes.ts: Add types ImportDeclarationMap and ImportCodeFixContext
minestarks Aug 10, 2017
380b299
Move getImportDeclarations into getCodeActionForImport, immediately a…
minestarks Aug 10, 2017
22c3373
importFixes.ts: Move createChangeTracker into getCodeActionForImport,…
minestarks Aug 10, 2017
8d5e075
importFixes.ts: Add convertToImportCodeFixContext function and refere…
minestarks Aug 10, 2017
2875c15
importFixes.ts: Add context: ImportCodeFixContext parameter to getCod…
minestarks Aug 10, 2017
e7d966b
importFixes.ts: Remove moduleSymbol parameter from getImportDeclarati…
minestarks Aug 10, 2017
e912a76
importFixes.ts: Use cachedImportDeclarations from context in getCodeA…
minestarks Aug 10, 2017
de7b821
importFixes.ts: Move createCodeAction out, immediately above convertT…
minestarks Aug 10, 2017
fa33d50
Move the declaration for lastImportDeclaration out of the getCodeActi…
minestarks Aug 10, 2017
13a47e2
importFixes.ts: Use symbolToken in getCodeActionForImport
minestarks Aug 10, 2017
8e5febb
importFixes.ts: Remove useCaseSensitiveFileNames altogether from getC…
minestarks Aug 10, 2017
2ea36a6
importFixes.ts: Remove local getUniqueSymbolId function and add check…
minestarks Aug 10, 2017
b11f6e8
importFixes.ts: Move getCodeActionForImport out into an export, immed…
minestarks Aug 10, 2017
72dd99f
completions.ts: In getCompletionEntryDetails, if there's symbolOrigin…
minestarks Aug 10, 2017
e68c951
importFixes.ts: Create and use importFixContext within getCodeActions…
minestarks Aug 10, 2017
bc14bb0
importFixes.ts: Use local newLineCharacter instead of context.newLine…
minestarks Aug 10, 2017
d1bdc25
importFixes.ts: Use local host instead of context.host in getCodeActi…
minestarks Aug 10, 2017
f0c983a
importFixes.ts: Remove dummy getCanonicalFileName line
minestarks Aug 10, 2017
a41f3df
Filter symbols after gathering exports instead of before
minestarks Aug 16, 2017
49bb2b8
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
minestarks Aug 16, 2017
211e3f9
Lint
minestarks Aug 16, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
session.ts, services.ts, types.ts: Add formattingOptions parameter to…
… getCompletionEntryDetails
  • Loading branch information
minestarks committed Aug 10, 2017
commit 8a1a12485675dfcc5cb15eff79762a9adbcbc90a
5 changes: 3 additions & 2 deletions src/server/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1201,9 +1201,10 @@ namespace ts.server {
const { file, project } = this.getFileAndProject(args);
const scriptInfo = project.getScriptInfoForNormalizedPath(file);
const position = this.getPosition(args, scriptInfo);

const formattingOptions = project.projectService.getFormatCodeOptions(file);

return mapDefined(args.entryNames, entryName => {
const details = project.getLanguageService().getCompletionEntryDetails(file, position, entryName);
const details = project.getLanguageService().getCompletionEntryDetails(file, position, entryName, formattingOptions);
if (details) {
const mappedCodeActions = map(details.codeActions, action => this.mapCodeAction(action, scriptInfo));
return { ...details, codeActions: mappedCodeActions };
Expand Down
3 changes: 2 additions & 1 deletion src/services/services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1373,8 +1373,9 @@ namespace ts {
return Completions.getCompletionsAtPosition(host, program.getTypeChecker(), log, program.getCompilerOptions(), getValidSourceFile(fileName), position);
}

function getCompletionEntryDetails(fileName: string, position: number, entryName: string): CompletionEntryDetails {
function getCompletionEntryDetails(fileName: string, position: number, entryName: string, formattingOptions?: FormatCodeSettings): CompletionEntryDetails {
synchronizeHostData();
formattingOptions;
return Completions.getCompletionEntryDetails(program.getTypeChecker(), log, program.getCompilerOptions(), getValidSourceFile(fileName), position, entryName);
}

Expand Down
2 changes: 1 addition & 1 deletion src/services/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ namespace ts {
getEncodedSemanticClassifications(fileName: string, span: TextSpan): Classifications;

getCompletionsAtPosition(fileName: string, position: number): CompletionInfo;
getCompletionEntryDetails(fileName: string, position: number, entryName: string): CompletionEntryDetails;
getCompletionEntryDetails(fileName: string, position: number, entryName: string, formattingOptions?: FormatCodeSettings): CompletionEntryDetails;
getCompletionEntrySymbol(fileName: string, position: number, entryName: string): Symbol;

getQuickInfoAtPosition(fileName: string, position: number): QuickInfo;
Expand Down