Skip to content

Filter + log undefined elements from the codeActions array #17811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

RyanCavanaugh
Copy link
Member

Fixes #17544. There's still an underlying bug somewhere (one of the CodeActions is returning undefined in an array position where it shouldn't) but without a repro it's going to be very hard to track down. This will replace the crash with a log message so we can figure out which action is responsible.

@RyanCavanaugh
Copy link
Member Author

🔔

@RyanCavanaugh RyanCavanaugh merged commit fa77e14 into microsoft:master Aug 29, 2017
@RyanCavanaugh RyanCavanaugh deleted the fix17544 branch August 29, 2017 22:32
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants