Mapped and indexed access type fixes #17455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
approved these changes
Aug 2, 2017
Closed
71 tasks
|
@ahejlsberg this fixes checks that were too loose, but there's been an inverse issue of checks that are too strict as well, see #15768. |
This was referenced Aug 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some missing checks related to indexed access types and mapped types. In particular, for an indexed access
T[K]the PR ensures that we always check thatKis assignable tokeyof T. This check was previously not performed whenTis a generic mapped type.Fixes #17238. This PR supercedes #17336, but keeps the tests from that PR.