Remove unused internal utilities #17380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
utils
branch
2 times, most recently
from
ae28cfb to
549f9fb
Compare
ghost
mentioned this pull request
sandersn
approved these changes
Jul 26, 2017
| @@ -26,20 +26,6 @@ namespace ts { | |||
| return undefined; | |||
| } | |||
|
|
|||
| export function findDeclaration<T extends Declaration>(symbol: Symbol, predicate: (node: Declaration) => node is T): T | undefined; | |||
There was a problem hiding this comment.
please don't remove this one. I use it in an upcoming change and would have to put it back.
There was a problem hiding this comment.
would it be fast enough to have getDeclarationOfKind delegate to findDeclaration ?
There was a problem hiding this comment.
Actually, the rewrite at the bottom of the change to find(symbol.declarations, ... is good enough since my new usage requires a cast as well.
(I also just merged the new usage, so you will see it when you merge from master.)
rbuckton
suggested changes
Aug 8, 2017
src/compiler/transformers/jsx.ts
Outdated
| @@ -114,7 +114,7 @@ namespace ts { | |||
| compilerOptions.reactNamespace, | |||
| tagName, | |||
| objectProperties, | |||
| filter(map(children, transformJsxChildToExpression), isDefined), | |||
| children && mapDefined(children, transformJsxChildToExpression), | |||
There was a problem hiding this comment.
Pretty much all of our other array utils in core.ts test for the array possibly being undefined. Should we not also do that for mapDefined?
|
@rbuckton Good to go? |
rbuckton
approved these changes
Aug 9, 2017
uniqueiniquity
pushed a commit
to uniqueiniquity/TypeScript
that referenced
this pull request
Aug 9, 2017
* Remove unused internal utilities * Handle undefined input to `mapDefined`
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the functions in
utilities.tsare not used.