Skip to content

Remove nonpublic members from destructuring completion lists #16953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

charlespierce
Copy link
Contributor

Fixes #15214

Filter out nonpublic properties from the list of "known" properties when doing an object binding.

@rbuckton rbuckton merged commit 31230b9 into microsoft:master Aug 7, 2017
@rbuckton
Copy link
Contributor

rbuckton commented Aug 7, 2017

This is a great improvement. Thanks for the contribution!

@charlespierce charlespierce deleted the destructure_completion_nonpublic branch October 6, 2017 01:33
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants