Add missing visitNode call to object literal members

[Yogu]

Object literal elements that are neither spread elements, nor property assignments would not have visitNode called on them. Therefore, the esnext transformer would not be called on them and their children.

Fixes #16765.

[msftclas]

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

[Yogu]

I added a test case, but now I get the error

Error: Debug Failure. False expression: Unexpected node.
Verbose Debug Information: Node MethodDeclaration did not pass test 'isExpression'.

The proposed fix worked fine when I directly changed it in the typescript.js of a project. Can anyone help me out with this? :)

[DanielRosenwasser]

Thanks for the PR Yogu!

We have a callback in visitNode called test which ensures that the node you're passing has an appropriate type. It's mostly a check to make sure that our assertions are correct. I believe the issue is that you need to update isExpression for the assertion to isObjectLiteralElementLike. Once that works, you should be able to baseline the resulting changes.

@rbuckton can you help look over this PR?

[Yogu]

@DanielRosenwasser Thanks. I wondered why we need to pass the static isExpression all the way down, somehow didn't connect the dots.

Now the build complains that the baseline file has changed. If I locally run the tests and then run jake baseline-accept, I don't get anything to stage into Git, though.

[DanielRosenwasser]

That's very strange. Are you able to manually add baselines from ./tests/baselines/local to ./tests/baselines/referenceandgit add` that?

[Yogu]

My bad, now it worked. The build now passes :)

[rbuckton]

One minor comment. Also, can you resolve the conflict below? Thanks!

[rbuckton]

You could remove the cast by changing the type of elements to ObjectLiteralElementLike[].

[Yogu]

@rbuckton Thanks for the comments. I resolved the conflicts and applied your suggestion. Can you look over it again?

[rbuckton]

Thanks for the contribution!

[rbuckton]

@mhegazy should I port this to release-2.5 as well?

[mhegazy]

yes please can you port it back.

[rbuckton]

This is now in release-2.5.