In TypeScript code, never bind JSDoc normally, just set parent pointers #16555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mhegazy
approved these changes
Jun 15, 2017
|
please port this to release-2.4 |
ghost
pushed a commit
that referenced
this pull request
Jun 15, 2017
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Jun 17, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16554
The fixes to #14752 (#14997) #16358 (#16413), and #16359 (#16416) were overly complex and specialized.
The only reason we needed to bind JSDoc in TypeScript code was to set parent pointers. This adds a function to do only that. (I started binding JSDoc in #15856 and should have just done this PR in the first place.)
Since we will now never reach a JSDoc node in the normal binder in TypeScript code, we can remove a bunch of checks for
isInJavaScriptFile(undoing the previous specialized fixes to the above issues).