Fix 'extends' with type parameter default returned from superclass construct signature #16502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
changed the title
sandersn
approved these changes
Jun 13, 2017
src/compiler/checker.ts
Outdated
| else { | ||
| result.push(sig); | ||
| } | ||
| } |
There was a problem hiding this comment.
It'd be nicer to keep it as an expression:
return map(signatures, sig => some(sig.typeParameters) ? getSignatureInstantiation(sig, typeArguments) : sig)
There was a problem hiding this comment.
Even better, use sameMap and save an allocation when none of them need to be instantiated (which is often the case).
ahejlsberg
approved these changes
Jun 13, 2017
src/compiler/checker.ts
Outdated
| else { | ||
| result.push(sig); | ||
| } | ||
| } |
There was a problem hiding this comment.
Even better, use sameMap and save an allocation when none of them need to be instantiated (which is often the case).
|
I will port this to release-2.4 tonight. |
|
This has been ported to release-2.4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
extendswhere the instantiation of a class-like "constructor" function used as a base class fails when the construct signature returns a type parameter default.This also fixes an issue where we were not reporting a grammar error for an empty type argument list in a heritage clause.
Fixes #16211