Skip to content

Update build scripts for npm5 #16160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2017
Merged

Update build scripts for npm5 #16160

merged 1 commit into from
May 31, 2017

Conversation

rbuckton
Copy link
Contributor

As of npm 5.0.0, npm will --save by default. Our build scripts for Travis and Jenkins both include the following steps:

npm uninstall typescript
npm uninstall tslint
npm install

Since since npm now saves changes to package.json by default, the npm install above will not reinstall the packages.

This change tells npm not to save changes during uninstall.

@rbuckton rbuckton merged commit 411cb45 into master May 31, 2017
@rbuckton rbuckton deleted the fixBuildScripts branch May 31, 2017 00:40
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@mhegazy mhegazy Awaiting requested review from mhegazy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuckton @DanielRosenwasser @msftclas