Skip to content

Set ScriptElementKind for enum members to "enum member" instead of "const" #13597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Mar 3, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jan 20, 2017

Fixes #13334 (and #9983)

@mhegazy
Copy link
Contributor

mhegazy commented Jan 21, 2017

You will need to make a matching change in VS to handle the new kind.

@ghost ghost force-pushed the enum_member branch from 674b3aa to ea26575 Compare January 31, 2017 15:40
@ghost ghost force-pushed the enum_member branch from ea26575 to 1c080d1 Compare February 14, 2017 14:36
@ghost
Copy link
Author

ghost commented Mar 1, 2017

The VS change is in, can this be merged?

@mhegazy
Copy link
Contributor

mhegazy commented Mar 1, 2017

Sure. make sure to test on VS 2015, VS 2017 and VS Code.

@ghost ghost merged commit 8bc21f9 into master Mar 3, 2017
@ghost ghost deleted the enum_member branch March 3, 2017 15:35
@ghost ghost mentioned this pull request Mar 3, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants