Use the value symbol for decorator purpose only if it is same as type symbol #13584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 20, 2017
|
|
||
| // Resolve the symbol as a type so that we can provide a more useful hint for the type serializer. | ||
| const typeSymbol = resolveEntityName(typeName, SymbolFlags.Type, /*ignoreErrors*/ true, /*dontResolveAlias*/ false, location); | ||
| if (valueSymbol && valueSymbol === typeSymbol) { |
There was a problem hiding this comment.
just wanna be enlightened about how Typescript type checker works:
if there's already a value called "Event" (like the DOM.Event class) and there is a type declared that is named "Event" and they are equal, we will assume that the reference is to the type rather than to the value?
There was a problem hiding this comment.
declarations do merge in TS, see http://www.typescriptlang.org/docs/handbook/declaration-merging.html for more details.
|
thanks for fixing this bug!! 🍾 💯 |
mhegazy
approved these changes
Jan 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13155