-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Fix --project help #13342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --project help #13342
Conversation
Hi @unional, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
@@ -2573,6 +2573,10 @@ | |||
"category": "Message", | |||
"code": 6039 | |||
}, | |||
"DIRECTORY_OR_FILE": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the _
from the message. so it should be FILE or DIRECTORY
@@ -2513,7 +2513,7 @@ | |||
"category": "Message", | |||
"code": 6019 | |||
}, | |||
"Compile the project in the given directory.": { | |||
"Compile the project in the given directory, using 'tsconfig.json' or the specified config file.": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compile a project given the path to its configuration file, or to a folder with a 'tsconfig.json'.
@@ -2513,7 +2513,7 @@ | |||
"category": "Message", | |||
"code": 6019 | |||
}, | |||
"Compile the project in the given directory.": { | |||
"Compile the project in the given directory, using 'tsconfig.json' or the specified config file.": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about:
Compile the project defined by the config file. Argument can be a full path to a config file, or a directory path to a directory containing 'tsconfig.json'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scrap that, i like @DanielRosenwasser's comment better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the message to match @DanielRosenwasser 's comment.
Oh, I just realized I did |
would work as well. |
Fixes #2867
#2867 (comment)
One concern is that the description is getting quite long.
Any suggestion?