Skip to content

Fix --project help #13342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2017
Merged

Fix --project help #13342

merged 2 commits into from
Jan 10, 2017

Conversation

unional
Copy link
Contributor

@unional unional commented Jan 7, 2017

Fixes #2867

#2867 (comment)

One concern is that the description is getting quite long.

Any suggestion?

@msftclas
Copy link

msftclas commented Jan 7, 2017

Hi @unional, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@@ -2573,6 +2573,10 @@
"category": "Message",
"code": 6039
},
"DIRECTORY_OR_FILE": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the _ from the message. so it should be FILE or DIRECTORY

@@ -2513,7 +2513,7 @@
"category": "Message",
"code": 6019
},
"Compile the project in the given directory.": {
"Compile the project in the given directory, using 'tsconfig.json' or the specified config file.": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compile a project given the path to its configuration file, or to a folder with a 'tsconfig.json'.

@@ -2513,7 +2513,7 @@
"category": "Message",
"code": 6019
},
"Compile the project in the given directory.": {
"Compile the project in the given directory, using 'tsconfig.json' or the specified config file.": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about:
Compile the project defined by the config file. Argument can be a full path to a config file, or a directory path to a directory containing 'tsconfig.json'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrap that, i like @DanielRosenwasser's comment better.

Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the message to match @DanielRosenwasser 's comment.

@mhegazy mhegazy merged commit 46938e0 into microsoft:master Jan 10, 2017
@unional unional deleted the fix-project-help branch January 10, 2017 06:06
@unional
Copy link
Contributor Author

unional commented Jan 10, 2017

Oh, I just realized I did FILE OR DIRECTORY instead of FILE or DIRECTORY.
Is that ok?

@mhegazy
Copy link
Contributor

mhegazy commented Jan 10, 2017

would work as well.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants