-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codefix for implementing interfaces #11547
Merged
Merged
Changes from 1 commit
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
1438f9a
Codefixes for implement interface and change extends to implements.
7a5cb5f
Merge branch 'pvb/codeaction/api' into interfaceFixes
bf3e487
Merge branch 'master' into interfaceFixes
6b4f6b5
Remove Type Assignability QuickFix
aozgaa 151f940
Refactor classDeclarations
aozgaa d1cea73
Refactor Loop
aozgaa c2feab6
Rename Tests
aozgaa f74872d
temp
aozgaa 2abf906
Merge branch 'master' into interfaceFixes
aozgaa 132b746
Covnert to Doc Comment
aozgaa ecc029f
more temp
aozgaa a66b0ae
Split CodeFixes in Separate Files
aozgaa 5d9a4e3
Move codeFixProvider.ts
aozgaa 3ac9ffa
Nerf Extends to implements For Now
aozgaa d24236b
Simplify getCodeFixChanges
aozgaa 7758e6d
Rename Most Tests
aozgaa 7272833
Rename and Add a Test
aozgaa 834245c
Add Failing Tests
aozgaa c89b97b
Add removeAbstractModifier Fix
aozgaa 16dc834
extends->implements w/ implements keyword present
aozgaa cbaea99
Cleanup Extends -> Interface Change
aozgaa bc21346
Refactor fourslash testing for codeFixes
aozgaa 99ae5d9
Remove unused tests
aozgaa aa6ecd4
Fix linting errors
aozgaa 3240000
Merge branch 'master' into interfaceFixes
aozgaa 0380f3f
Recognize modifiers
aozgaa 1b60a97
Remove unused
aozgaa e5279fd
Rename and simplify fourslash interface
aozgaa 04968ab
fix references to codefixes?
aozgaa d02eb6c
fix jakefile1
aozgaa 3b0b696
broken
aozgaa 36c5bef
Add tests and simplify existing ones
aozgaa 1b8486d
Still re-writing missing member grabber
aozgaa b7b30aa
Add straggling Test
aozgaa 71d1744
Test Fixes
aozgaa 8c35185
Expose More TypeChecker
aozgaa bc1bb0e
Make test failure more readable
aozgaa 0ce53f0
rename tests
aozgaa b26ba83
Expose signatureToString, addSupressAnyReturn Flag
aozgaa 11cea6a
Use TypeChecker to Get Types, Print
aozgaa 7141a2a
Better error message in fourslash
aozgaa 55bf3e3
Use new engine for interface fixes
aozgaa 4441380
tests: edit expected type params
aozgaa 1ec234a
Edit error handling tests
aozgaa 6bd35fb
Fix Type Param method Tests
aozgaa 4973852
fix linter errors
aozgaa 1d6ef6a
cleanup
aozgaa d842a6f
Merge branch 'master' into interfaceFixes
aozgaa b1e97b3
Get one fix per interface
aozgaa c650c33
Update tests
aozgaa 0591e1b
Simplify Testing
aozgaa 263734f
Add a test
aozgaa 4b202ab
Initialize result to empy array
aozgaa 357ed7e
Remove Inner Loop
aozgaa f6fc320
Get Ancestor instead of manual walk
aozgaa efd16c7
Spell out names fully
aozgaa bba96da
remove multiple implements TODO
aozgaa cfe50d1
Fix extends -> implements for decorators/modifiers
aozgaa ad3035d
remove generated file from PR
aozgaa d8b359f
Fix typo and capitalization
aozgaa 6400d53
Fix handling of default class
aozgaa c010a0e
Use getTypeOfSymbolAtLocation
aozgaa 395d736
Remove getSymbolOfNode from TypeChecker interface
aozgaa d7d4bf6
Handle class expressions
aozgaa a94d955
Aggregate changes before building result
aozgaa 43afb80
remove fix
aozgaa 6ed8d18
unexpose resolveStructuredTypeMembers
aozgaa 389959a
Merge branch 'master' into interfaceFixes
aozgaa 69118cd
Merge branch 'master' into interfaceFixes
4af0e2a
Merge branch 'master' into interfaceFixes
680af0f
use getStart()
16b146f
Use array instead of map
f37640a
Add args to diagnostic message
5d6a714
move helpers under codefix dir
bf48564
FIx typo in method stub.
ba80ce6
stubbing extra completions
8134d64
Merge branch 'master' into interfaceFixes
0c1772b
Merge branch 'interfaceFixes' of https://github.com/Microsoft/TypeScr…
f0c7713
implement getters/setters as property
c511aea
Add Support for multiple signatures
5cd0ea3
handle well-known computed property/method names
c22e47d
add test for computed literals
c1a41b9
Expose indexSignaturePrinting
2f51b36
add missing index signature support
97b3d7a
make index signature fix work with generics
819a654
Add tests and fix rest parameters
5e48e33
cleanup
1338b94
Simplify rest parameter handling
b9ae36c
Simplify index signature generation
d724517
Merge branch 'master' into interfaceFixes
469745b
Synthetic signature uses existing parameter names
1ba6c86
Merge branch 'master' into interfaceFixes
ad01110
Consolidate Tests
3cfac08
abstract class expr instantiation and abstract fix works with class expr
4673812
refactor fix
4b02099
add tests
8be8819
simplify and inline methods
d75d548
implicit any for synthesized signature
4af3937
Merge branch 'master' into interfaceFixes
97f18c9
Cleanup
3fc94bb
Rename Tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Synthetic signature uses existing parameter names
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format is a little hard to read