Skip to content

avoid creating syntax nodes for jsdoc comment tags #10526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2016

Conversation

zhengbli
Copy link
Contributor

This PR avoid creating syntax lists children for things in between jsdoc tags. It wasn't useful to keep them, and that way we don't need to skip them later.

@sandersn
Copy link
Member

What bug does this fix?
Otherwise 👍 ... as far as I understand this code, which is not much.
(I recently ran into problems in this code in the new-jsdoc-parser-WIP branch, so if this doesn't fix them, I'll probably come ask you to explain what you know about it.)

@zhengbli
Copy link
Contributor Author

This is a change based on #10407, which solves #9650 but still creates the synthetic nodes and skip them, so it does some unnecessary work.

Sure let me know if you have any questions.

@sandersn
Copy link
Member

I tried this on the new jsdoc parser and things got a lot better. 👍 🎮

@zhengbli zhengbli merged commit 8d5aaf8 into microsoft:master Aug 25, 2016
@zhengbli zhengbli deleted the dontCreateSyntaxListForJsDoc branch August 25, 2016 21:26
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants