Add error message

[YuichiNukiyama]

Fixes #10351
Reference https://developer.mozilla.org/en-US/docs/Glossary/Primitive
Add error message when trying to relate primitives to the boxed/apparent backing types.

[DanielRosenwasser]

You don't want to do this because you might be in a context where Number has been shadowed to something else.

You also need to cover Symbol/symbol.

Instead, do a check against

• globalStringType/stringType
• globalNumberType/numberType
• globalBooleanType/booleanType
• getGlobalESSymbolType()/esSymbolType

[DanielRosenwasser]

Also, I don't think you necessarily want to do this here. I think you want to have a separate function for this logic right before this line in isRelatedTo:

if (reportErrors) {
    reportRelationError(headMessage, source, target);
}

So before that, I'd have a check like

if (source.flags & TypeFlags.ObjectType && target.flags & TypeFlags.Primitive) {
    tryElaborateErrorsForPrimitivesAndObjects(source, target);
}

[DanielRosenwasser]

Looks like a nice improvement in the baselines! 😄

[YuichiNukiyama]

@DanielRosenwasser Thanks your kindfull advise. I have no idea why some tests fail. Do you have any ideas?

[DanielRosenwasser]

Whoops - that's being caused by the assertion in reportError. Basically you'll need to move the new change into the

if (reportErrors) {
    // ...
}

block in isRelatedTo.

[YuichiNukiyama]

@DanielRosenwasser Nice 👍 I could resolve my issues.

[DanielRosenwasser]

Nice job! @RyanCavanaugh and @sandersn, any feedback?

[RyanCavanaugh]

The ES spec refers to these as "wrapper objects" and doesn't use the term "box". I would prefer something like

'string' is a primitive, but 'String' is a wrapper object. Prefer using 'string' when possible.

Thoughts?

[DanielRosenwasser]

Let's go with Ryan's suggestion and I think we'll be good to pull in.

[YuichiNukiyama]

change error message.