Salsa: "Implicit globals" leak into member completions but not global completions?

[egamma]

From @alexandrudima on January 27, 2016 13:34

Testing #2218

IMHO member completions should get less suggestions than the global completions, not the other way around:

function f() {
    // helloWorld leaks from here into the global space?
    if (helloWorld) {
        return 3;
    }
    return 5;
}

// helloWorld is proposed here
// Number(3).

// helloWorld is not proposed here
// hello

Copied from original issue: microsoft/vscode#2447

[RyanCavanaugh]

@billti how should we fix this?

• Add all tokens in the current file to the global completion list. -- or --
• Remove token-based items from the member list (when it is non-empty)

[mhegazy]

the later is an problem when we guess things wrong:

var x = {};
x.a = 0;
x.b = "string";
x.|

The earlier seems like a more consistent approach. VSCode should show these completions as a different icon. the CompletionEntry.kind field should be the marker here, also CompletionEntry.sortKey should push these all to the bottom.

[egamma]

VSCode should show these completions as a different icon.

@mhegazy we have already changed the icon in our latest:

.