Skip to content

Trailing comma in dynamic import should be allowed also when used in a typeof typeΒ #61489

Open
@nicolo-ribaudo

Description

@nicolo-ribaudo

πŸ”Ž Search Terms

trailing comma dynamic import

πŸ•— Version & Regression Information

  • This is the behavior in every version I tried

⏯ Playground Link

https://www.typescriptlang.org/play/?#code/CYUwxgNghgTiAEBbA9sArhBAiAZs5W8A3gL4BQZYyAdgM4Au8AbvALzxQDuUAloz4gAOyGPQAUufFgA0ASgDcZegE9BCACpt4KtchzwBw0RLwE5iyjQbMATFq69+QkeMlnS5pao132OkHoGzsZuMh4KZEA

πŸ’» Code

declare module "foo" {}

const v = await import("foo",);
type T = typeof import("foo",);

const v2 = await import("foo",{},);
type T2 = typeof import("foo",{},);

πŸ™ Actual behavior

The trailing commas in the type-level import()s are reported as syntax error

πŸ™‚ Expected behavior

The syntax of import() at the type-level should match the one at the value level, thus allowing trailing commas.

Additional information about the issue

Note that the error was correct before import attributes, but import attributes changed the dynamic import syntax to allow trailing commas.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Help WantedYou can do thisPossible ImprovementThe current behavior isn't wrong, but it's possible to see that it might be better in some cases

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions