Skip to content

Design Meeting Notes, 1/31/2024 #57254

Closed
Closed
@DanielRosenwasser

Description

@DanielRosenwasser

Notes from @RyanCavanaugh

JSDoc import *

#41825

  • Annoying to have to write import()s over and over again
  • @importType * as Foo from "bar"
  • @importType { destr } from "bar"
  • Or just @import instead? It's unambiguous
  • Peeps generally preferred the latter
  • What about an inverted from x import y ?
    • Ehh, mirroring ES syntax is better even if it's worse for completion
  • type modifier seems unnecessary since it's implicitly in a type context
    • Should we allow it as a no-op?
      • Start with no, see what happens
  • Do we support trailing comments at the end of lines?
    • How do we know when the code ends? New keywords can and have appeared after the module specifier
    • Just lookahead
    • Need many testcases around various whitespace/newline combinations
  • Do we really need to support multiline variants? Seems complex
    • We already have helpers to correctly deal with eating the start of line

Set methods

#57230

  • Should the set boolean algebra functions enforce matching, or be generic?
  • Many trade-offs
    • Generic: s.intersect(t) matches t.intersect(s)
    • Generic: sup.intersect(sub) produces Set<sub> instead of Set<sup> (good)
    • Nongeneric: strs.intersect(nums) gets detected as an error
  • After much debate: Use generics

Metadata

Metadata

Assignees

No one assigned

    Labels

    Design NotesNotes from our design meetings

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions