Skip to content

Move to file fails when selecting existing with: Expected isNewFile for (only) new files #54285

Closed
@mjbvz

Description

@mjbvz

Bug Report

🔎 Search Terms

  • refactor
  • refactoring

🕗 Version & Regression Information

5.1.0-dev.20230509

Repo

  1. For the code:
export const a = 1;
const b = 2;
console.log(a, b);
  1. Select the first line and try running move to existing file
  2. Select an existing file (in this case, an empty file)

bug

See the following error for the request:

2023-05-16 17:02:06.057 [trace] <semantic> Sending request: getEditsForRefactor (119). Response expected: yes. Current queue length: 0 {
    "file": "/Users/matb/projects/san/x.ts",
    "startLine": 1,
    "startOffset": 1,
    "endLine": 1,
    "endOffset": 20,
    "action": "Move to file",
    "refactor": "Move to file",
    "interactiveRefactorArguments": {
        "targetFile": "/Users/matb/projects/san/other.ts"
    }
}
2023-05-16 17:02:06.061 [trace] <semantic> Response received: getEditsForRefactor (119). Request took 3 ms. Success: false . Message: Error processing request. Debug Failure. Expected isNewFile for (only) new files. {"isNewFile":true,"hasScriptInfo":true}
Error: Debug Failure. Expected isNewFile for (only) new files. {"isNewFile":true,"hasScriptInfo":true}
    at IpcIOSession.mapTextChangeToCodeEdit (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:181970:13)
    at /Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:181962:46
    at Array.map (<anonymous>)
    at IpcIOSession.mapTextChangesToCodeEdits (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:181962:25)
    at IpcIOSession.getEditsForRefactor (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:181842:21)
    at getEditsForRefactor (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:180076:43)
    at /Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:182201:69
    at IpcIOSession.executeWithRequestId (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:182193:14)
    at IpcIOSession.executeCommand (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:182201:29)
    at IpcIOSession.onMessage (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:182243:51)
    at process.<anonymous> (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:183823:14)
    at process.emit (node:events:513:28)
    at process.emit (/Users/matb/projects/vscode/node_modules/source-map-support/source-map-support.js:395:21)
    at emit (node:internal/child_process:939:14)
    at processTicksAndRejections (node:internal/process/task_queues:84:21)

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptDomain: Refactoringse.g. extract to constant or function, rename symbolFix AvailableA PR has been opened for this issue

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions