Skip to content

Inference regression (5.0.4 vs 4.9.5) with nullable enum function parameterΒ #54005

Closed
@cakoose

Description

@cakoose

Bug Report

πŸ”Ž Search Terms

inference string null function parameter

πŸ•— Version & Regression Information

  • This changed between versions 4.9.5 and 5.0.4

⏯ Playground Link

Playground link with relevant code

πŸ’» Code

enum Thing { a = 'a', b = 'b', };

function f(
    registrationStatusOptions: SelectOptions<Thing>,
    onChange: (status: Thing | null) => void, // <-- Remove the `| null` and the error goes away.
): void {
    select({ // <-- Add an explicit type argument `Thing` and the error goes away.
        options: registrationStatusOptions,
        onChange: onChange, // ERROR in v5.0.4 but not in v4.9.5: Type '(status: Thing | null) => void' is not assignable to type '(key: string) => void'.
    });
}

export function select<KeyT extends string>(props: SelectProps<KeyT>): void {
    throw new Error('hello');
}

export type SelectProps<KeyT extends string> = {
    onChange: (key: KeyT) => void;
    options?: SelectOptions<KeyT>; // <-- Remove the `?` and the error goes away.
};

export type SelectOptions<KeyT extends string> =
    // Comment either of the below union members out and the error goes away.
    | Array<{key: KeyT}>
    | Array<KeyT>;

πŸ™ Actual behavior

  1. Got a type error; see "ERROR" comment above. Looks like the type argument to select(...) is being inferred incorrectly.
  2. Minor perturbations of the code cause the error to go away; see other comments above.

This was extracted from some React UI code.

πŸ™‚ Expected behavior

TypeScript 4.9.5 infers the type argument I wanted. I was hoping TypeScript 5.0.4 would do the same.

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptFix AvailableA PR has been opened for this issue

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions