Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate auto-import completions when ATA transitively installs a different version of something installed locally #52708

Open
andrewbranch opened this issue Feb 9, 2023 · 0 comments
Assignees
Labels
Bug A bug in TypeScript Domain: Auto-import Domain: JavaScript The issue relates to JavaScript specifically
Milestone

Comments

@andrewbranch
Copy link
Member

Bug Report

Repro: see completions for Minipass in the npm/cli repo. One is from the locally installed dependency, and the other is in the ATA cache because @types/fs-minipass (installed by ATA) depends on a different version of minipass than the one locally available. It doesn’t seem possible/correct for ATA to filter this dependency out since the locally available one doesn’t match the version required by @types/fs-minipass, so the ExportInfoMap should filter this out.

@andrewbranch andrewbranch self-assigned this Feb 9, 2023
@andrewbranch andrewbranch added Bug A bug in TypeScript Domain: JavaScript The issue relates to JavaScript specifically Domain: Auto-import labels Feb 9, 2023
@andrewbranch andrewbranch added this to the TypeScript 5.1.0 milestone Feb 9, 2023
@andrewbranch andrewbranch modified the milestones: TypeScript 5.1.0, Backlog Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: Auto-import Domain: JavaScript The issue relates to JavaScript specifically
Projects
None yet
Development

No branches or pull requests

1 participant