Bug report: Comment node is removed after "Extract to function in module scope

[aghArdeshir]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.68.1
• OS Version: Ubuntu 22.04

NOTE: I couldn't find this option in VSCode Insiders! (Maybe it is removed)

Hi. When I refactor a callback in my JSX, which does something rather complicated, one of my comments are removed.

Code example:

//@ts-nocheck
/* eslint-disable */

export default function Something() {
  return (
    <SomeComponent
      aCallbackThatProducesAReactNode={() => {
        // this comment will be kept intact
        const someProps = {
          prop1: props.props1, // BUT THIS COMMENT WILL BE REMOVED :(

          prop2: props.props2 // this comment will be kept intact too
        };

        return <SomeOtherComponent {...someProps} />;
      }}
    />
  );
}

Try refactoring the whole callback into a function in module scope.

One:

Two:

Three:

As you see one of my comments are removed.

Thanks.

[babakks]

I traced the problem, and it seems like it's rooted in the emitter.

For example, take this simple input, named sample.ts:

// Comment
const a = {
    p0: 0, // Comment
    p1: 0, /* Comment */
};

Compile it with:

tsc sample.ts 

The emitted JS file would be:

// Comment
var a = {
    p0: 0,
    p1: 0
};

Which has two comments missing. I used v4.7.4.

@RyanCavanaugh I think this is more serious now. What's your opinion?

[aghArdeshir]

Hi. Thanks for the follow-up. I just noticed this issue is moved to TypeScript from VSCode, I don't know the reason. Would somebody please explain? ❤️

Thanks ❤️

[babakks]

@aghArdeshir Because code actions (e.g., "extract function" or "extract constant") are TypeScript language services which reside in this repository and any invocation at the VS Code side ends up here.

[aghArdeshir]

Thank you very much Babak jan 👍

[babakks]

@RyanCavanaugh I've submitted a PR to fix this. Could you please check it? (#50097)