[NewErrors] 4.8.0-dev.20220609 vs 4.7.3

[typescript-bot]

The following errors were reported by 4.8.0-dev.20220609, but not by 4.7.3

kamranahmedse/developer-roadmap

tsconfig.json

• error TS2344: Type 'K' does not satisfy the constraint 'Record<string, any>'.
  • file:///mnt/ts_downloads/developer-roadmap/node_modules/@chakra-ui/descendant/src/use-descendant.ts#L11
  • file:///mnt/ts_downloads/developer-roadmap/node_modules/@chakra-ui/descendant/src/use-descendant.ts#L87
  • file:///mnt/ts_downloads/developer-roadmap/node_modules/@chakra-ui/descendant/src/use-descendant.ts#L91

coder/code-server

7 of 57 projects failed to build with the old tsc

src/tsconfig.monaco.json

• error TS2322: Type '(_target: T, propKey: PropertyKey) => unknown' is not assignable to type '(target: object, p: string | symbol, receiver: any) => any'.
  • src/vs/base/parts/ipc/common/ipc.ts#L1116

src/tsconfig.tsec.json

• error TS2322: Type '(_target: T, propKey: PropertyKey) => unknown' is not assignable to type '(target: object, p: string | symbol, receiver: any) => any'.
  • src/vs/base/parts/ipc/common/ipc.ts#L1116
• error TS2322: Type 'T' is not assignable to type 'RemoteServiceStub<T>'.
  • src/vs/platform/ipc/electron-sandbox/services.ts#L23
• error TS2409: Return type of constructor signature must be assignable to the instance type of the class.
  • src/vs/platform/ipc/electron-sandbox/services.ts#L23

microsoft/playwright

4 of 9 projects failed to build with the old tsc

packages/html-reporter/tsconfig.json

• error TS2344: Type 'T' does not satisfy the constraint 'Channel'.
  • packages/playwright-core/src/client/connection.ts#L59

vercel/hyper

2 of 3 projects failed to build with the old tsc

tsconfig.json

• error TS2344: Type 'BaseType' does not satisfy the constraint 'Record<string | number, any>'.
  • file:///mnt/ts_downloads/hyper/app/node_modules/type-fest/ts41/get.d.ts#L93 in app/tsconfig.json
  • file:///mnt/ts_downloads/hyper/app/node_modules/type-fest/ts41/get.d.ts#L94 in app/tsconfig.json
• error TS2344: Type 'T' does not satisfy the constraint 'Record<string, any>'.
  • file:///mnt/ts_downloads/hyper/app/node_modules/conf/dist/source/types.d.ts#L201 in app/tsconfig.json

react-hook-form/react-hook-form

2 of 3 projects failed to build with the old tsc

tsconfig.json

• error TS2344: Type 'TFieldValues' does not satisfy the constraint 'FieldValues'.
  • src/tests/controller.test.tsx#L21
  • src/logic/getResolverOptions.ts#L27
  • src/types/fieldArray.ts#L99
  • src/types/fieldArray.ts#L99
  • src/types/fieldArray.ts#L102
  • src/types/fieldArray.ts#L103
  • src/types/fieldArray.ts#L130
  • src/types/fieldArray.ts#L130
  • src/types/fieldArray.ts#L133
  • src/types/fieldArray.ts#L134
  • src/types/fieldArray.ts#L183
  • src/types/fieldArray.ts#L183
  • src/types/fieldArray.ts#L187
  • src/types/fieldArray.ts#L188
  • src/types/fieldArray.ts#L214
  • src/types/fieldArray.ts#L214
  • src/types/fieldArray.ts#L217
  • src/types/fieldArray.ts#L240
  • src/types/fieldArray.ts#L240
  • src/types/fieldArray.ts#L243
  • src/types/fieldArray.ts#L244
  • src/types/form.ts#L117
  • src/types/form.ts#L121
  • src/types/form.ts#L125
  • src/types/form.ts#L140
  • src/types/form.ts#L706
  • src/types/form.ts#L706
  • src/types/form.ts#L710
  • src/types/form.ts#L757
  • src/types/form.ts#L785
  • src/types/form.ts#L788
  • src/types/form.ts#L789
  • src/types/form.ts#L790
  • src/types/resolvers.ts#L22
  • src/useWatch.ts#L147
• error TS2344: Type 'T' does not satisfy the constraint 'FieldValues'.
  • src/tests/useController.test.tsx#L561
  • src/tests/useController.test.tsx#L562
• error TS2322: Type 'Control<T, any>' is not assignable to type 'Control<FieldValues, any>'.
  • src/tests/useController.test.tsx#L567
• error TS2345: Argument of type 'U' is not assignable to parameter of type 'Partial<{ shouldValidate: boolean; shouldDirty: boolean; shouldTouch: boolean; }> | undefined'.
  • src/logic/createFormControl.ts#L603
• error TS2533: Object is possibly 'null' or 'undefined'.
  • src/logic/getFieldValueAs.ts#L14
  • src/logic/validateField.ts#L121

typeorm/typeorm

tsconfig.json

• error TS2344: Type 'Entity' does not satisfy the constraint 'ObjectLiteral'.
  • src/data-source/DataSource.ts#L430
  • src/data-source/DataSource.ts#L450
  • src/entity-manager/EntityManager.ts#L1287
  • src/entity-manager/EntityManager.ts#L1344
  • src/entity-manager/EntityManager.ts#L1353
  • src/globals.ts#L180
  • src/globals.ts#L222
  • src/repository/TreeRepository.ts#L15
• error TS2345: Argument of type 'DeepPartial<Entity>' is not assignable to parameter of type 'ObjectLiteral'.
  • src/entity-manager/EntityManager.ts#L311
  • src/entity-manager/EntityManager.ts#L333
• error TS2345: Argument of type 'T | T[]' is not assignable to parameter of type 'ObjectLiteral | ObjectLiteral[]'.
  • src/entity-manager/EntityManager.ts#L433
  • src/entity-manager/EntityManager.ts#L573
  • src/entity-manager/EntityManager.ts#L646
• error TS2345: Argument of type 'Entity | Entity[]' is not assignable to parameter of type 'ObjectLiteral | ObjectLiteral[]'.
  • src/entity-manager/EntityManager.ts#L500
• error TS2345: Argument of type 'EntityTarget<Entity>' is not assignable to parameter of type 'EntityTarget<ObjectLiteral>'.
  • src/entity-manager/EntityManager.ts#L1297
  • src/entity-manager/EntityManager.ts#L1359
• error TS2322: Type 'MongoRepository<ObjectLiteral>' is not assignable to type 'Repository<Entity>'.
  • src/entity-manager/EntityManager.ts#L1302
• error TS2345: Argument of type 'Entity[]' is not assignable to parameter of type 'ObjectLiteral[]'.
  • src/entity-manager/MongoEntityManager.ts#L1103
  • src/entity-manager/MongoEntityManager.ts#L1119
• error TS2345: Argument of type 'E1 | E1[]' is not assignable to parameter of type 'ObjectLiteral | ObjectLiteral[]'.
  • src/query-builder/RelationIdLoader.ts#L78
  • src/query-builder/RelationIdLoader.ts#L91
• error TS2345: Argument of type 'Entity' is not assignable to parameter of type 'ObjectLiteral | undefined'.
  • src/query-builder/SoftDeleteQueryBuilder.ts#L414
  • src/query-builder/UpdateQueryBuilder.ts#L445
  • src/repository/TreeRepository.ts#L216
  • src/repository/TreeRepository.ts#L390
• error TS2322: Type 'Entity[]' is not assignable to type 'ObjectLiteral[]'.
  • src/query-builder/SoftDeleteQueryBuilder.ts#L423
  • src/query-builder/UpdateQueryBuilder.ts#L454
• error TS2345: Argument of type 'T' is not assignable to parameter of type 'ObjectLiteral'.
  • src/query-builder/transformer/PlainObjectToNewEntityTransformer.ts#L23
• error TS2344: Type 'T' does not satisfy the constraint 'ObjectLiteral'.
  • src/repository/AbstractRepository.ts#L88
  • test/github-issues/8681/issue-8681.ts#L49
• error TS2345: Argument of type 'Entity' is not assignable to parameter of type 'ObjectLiteral'.
  • src/repository/TreeRepository.ts#L154
  • src/repository/TreeRepository.ts#L192
  • src/repository/TreeRepository.ts#L325
  • src/repository/TreeRepository.ts#L365
• error TS2769: No overload matches this call.
  • test/github-issues/2871/enumTools.ts#L19
• error TS2322: Type 'Repository<ObjectLiteral>' is not assignable to type 'Repository<T>'.
  • test/github-issues/8681/issue-8681.ts#L51

mobxjs/mobx

7 of 9 projects failed to build with the old tsc

packages/mobx/tsconfig.json

• error TS2322: Type 'IIsObservableObject & Object' is not assignable to type 'T'.
  • packages/mobx/src/api/observable.ts#L214
• error TS2345: Argument of type 'T' is not assignable to parameter of type 'Object'.
  • packages/mobx/src/api/observable.ts#L218

palantir/blueprint

11 of 25 projects failed to build with the old tsc

packages/datetime/src/tsconfig.json

• error TS2339: Property 'className' does not exist on type '{}'.
  • packages/datetime/src/dateInput.tsx#L237
• error TS2339: Property 'popoverClassName' does not exist on type '{}'.
  • packages/datetime/src/dateInput.tsx#L241
• error TS2339: Property 'onClose' does not exist on type '{}'.
  • packages/datetime/src/dateInput.tsx#L284

packages/select/src/tsconfig.json

• error TS2339: Property 'fill' does not exist on type '{}'.
  • packages/select/src/components/multi-select/multiSelect.tsx#L161
  • packages/select/src/components/multi-select/multiSelect.tsx#L162
  • packages/select/src/components/select/select.tsx#L164
  • packages/select/src/components/suggest/suggest.tsx#L197
• error TS2339: Property 'inputProps' does not exist on type '{}'.
  • packages/select/src/components/multi-select/multiSelect.tsx#L167
  • packages/select/src/components/multi-select/multiSelect.tsx#L168
• error TS2339: Property 'className' does not exist on type '{}'.
  • packages/select/src/components/multi-select/multiSelect.tsx#L186
  • packages/select/src/components/multi-select/multiSelect.tsx#L199
  • packages/select/src/components/select/select.tsx#L207
  • packages/select/src/components/suggest/suggest.tsx#L209
• error TS2339: Property 'popoverClassName' does not exist on type '{}'.
  • packages/select/src/components/multi-select/multiSelect.tsx#L189
  • packages/select/src/components/select/select.tsx#L209
  • packages/select/src/components/suggest/suggest.tsx#L212
• error TS2339: Property 'modifiers' does not exist on type '{}'.
  • packages/select/src/components/select/select.tsx#L168
  • packages/select/src/components/select/select.tsx#L169
  • packages/select/src/components/select/select.tsx#L172
• error TS7006: Parameter 'data' implicitly has an 'any' type.
  • packages/select/src/components/select/select.tsx#L174
• error TS2339: Property 'usePortal' does not exist on type '{}'.
  • packages/select/src/components/select/select.tsx#L181
• error TS2339: Property 'wrapperTagName' does not exist on type '{}'.
  • packages/select/src/components/select/select.tsx#L182

apollographql/apollo-client

tsconfig.json

• error TS2345: Argument of type '{ store: EntityStore; rootId: string; config: InMemoryCacheConfig; previousResult?: any; optimistic: boolean; returnPartialData?: boolean | undefined; canonizeResults?: boolean | undefined; query: DocumentNode | TypedDocumentNode<...>; variables?: TVariables | undefined; id?: string | undefined; }' is not assignable to parameter of type 'DiffQueryAgainstStoreOptions'.
  • src/cache/inmemory/inMemoryCache.ts#L232
• error TS2345: Argument of type 'SubscriptionOptions<TVariables, T>' is not assignable to parameter of type 'SubscriptionOptions<OperationVariables, any>'.
  • src/core/ApolloClient.ts#L364
• error TS2322: Type 'TSubscriptionVariables | undefined' is not assignable to type 'OperationVariables | undefined'.
  • src/core/ObservableQuery.ts#L515
• error TS2345: Argument of type 'TVariables' is not assignable to parameter of type 'OperationVariables | undefined'.
  • src/core/QueryManager.ts#L196
• error TS2345: Argument of type 'TVariables | undefined' is not assignable to parameter of type 'OperationVariables | undefined'.
  • src/core/QueryManager.ts#L239
• error TS2322: Type 'ObservableQuery<T, TVariables>' is not assignable to type 'ObservableQuery<any, OperationVariables>'.
  • src/core/QueryManager.ts#L644
• error TS2322: Type 'TVariables | undefined' is not assignable to type 'Record<string, any> | undefined'.
  • src/core/QueryManager.ts#L645
• error TS2345: Argument of type 'TVars | undefined' is not assignable to parameter of type 'OperationVariables | undefined'.
  • src/core/QueryManager.ts#L1041
• error TS2345: Argument of type 'Pick<WatchQueryOptions<TVars, TData>, "variables" | "context" | "fetchPolicy" | "errorPolicy">' is not assignable to parameter of type 'Pick<WatchQueryOptions<OperationVariables, any>, "variables" | "fetchPolicy" | "errorPolicy">'.
  • src/core/QueryManager.ts#L1056
• error TS2345: Argument of type 'TVars | (undefined & TVars)' is not assignable to parameter of type 'OperationVariables | undefined'.
  • src/core/QueryManager.ts#L1153
• error TS2345: Argument of type '(variables: TVars) => ConcastSourcesIterable<ApolloQueryResult<TData>>' is not assignable to parameter of type '(value: { [x: string]: any; }) => ConcastSourcesIterable<ApolloQueryResult<TData>> | PromiseLike<ConcastSourcesIterable<ApolloQueryResult<TData>>>'.
  • src/core/QueryManager.ts#L1155
• error TS2345: Argument of type 'WatchQueryOptions<TVars, TData>' is not assignable to parameter of type 'WatchQueryOptions<OperationVariables, any>'.
  • src/core/QueryManager.ts#L1163
• error TS2322: Type 'TVars | undefined' is not assignable to type 'Record<string, any> | undefined'.
  • src/core/QueryManager.ts#L1346
  • src/core/QueryManager.ts#L1376
• error TS2345: Argument of type 'TVars | undefined' is not assignable to parameter of type 'Record<string, any> | undefined'.
  • src/core/QueryManager.ts#L1350
• error TS2345: Argument of type 'OperationOption<TProps, TData, TGraphQLVariables, TChildProps, DefaultContext, ApolloCache<any>>' is not assignable to parameter of type 'OperationOption<TProps, Record<string, any>, TGraphQLVariables, TChildProps, DefaultContext, ApolloCache<any>>'.
  • src/react/hoc/graphql.tsx#L28
• error TS2322: Type '(mutate: MutationFunction<TData, TGraphQLVariables>, { data, ...r }: MutationResult<TData>) => JSX.Element' is not assignable to type '(mutateFunction: MutationFunction<any, OperationVariables, DefaultContext, ApolloCache<any>>, result: MutationResult<...>) => Element | null'.
  • src/react/hoc/mutation-hoc.tsx#L75
• error TS2322: Type 'TProps & TChildProps' is not assignable to type 'IntrinsicAttributes & TProps & TChildProps & { children?: ReactNode; }'.
  • src/react/hoc/mutation-hoc.tsx#L105
  • src/react/hoc/query-hoc.tsx#L89
  • src/react/hoc/query-hoc.tsx#L119
  • src/react/hoc/subscription-hoc.tsx#L108
  • src/react/hoc/subscription-hoc.tsx#L138
• error TS2322: Type 'TChildProps' is not assignable to type '{ [x: string]: any; }'.
  • src/react/hoc/query-hoc.tsx#L115
  • src/react/hoc/subscription-hoc.tsx#L134
• error TS2769: No overload matches this call.
  • src/utilities/common/cloneDeep.ts#L30
• error TS2345: Argument of type 'TRelayEdge<TNode>' is not assignable to parameter of type 'Reference | StoreObject | undefined'.
  • src/utilities/policies/pagination.ts#L110

[DanielRosenwasser]

Common issue is something like

export interface Obj {
    [key: string]: any
}

function foo<T>(x: T) {
    let y: Obj = x;
}

[andrewbranch]

@typescript-bot bisect good v4.7.3 bad main

[typescript-bot]

The change between v4.7.3 and main occurred at 5aa0053.

[andrewbranch]

It’s nonsense because I didn’t add // @strictNullChecks: true to the repro. But I wonder what change it thinks it picked up on, hah

[ahejlsberg]

@DanielRosenwasser I'm pretty sure that comes from #49119 (which incorporated the change from #48366). When checking whether an unconstrained type parameter T is assignable to some type X, we used to check whether {} is assignable to X. We now check whether unknown is assignable to X, and in this case it isn't because T could be undefined or null. This seems like a very legit error.

[typescript-bot]

👋 Hi, I'm the Repro bot. I can help narrow down and track compiler bugs across releases! This comment reflects the current state of this repro running against the nightly TypeScript.

---

Comment by @DanielRosenwasser

❌ Failed: -

• Type 'T' is not assignable to type 'Obj'.

Historical Information

Version	Reproduction Outputs
4.3.2, 4.4.2, 4.5.2, 4.6.2, 4.7.2	👍 Compiled

[meg2208]

Is there any plan to resolve typeorm/typeorm#9331? This is a very extensively used dependency and it doesn't seem like a straightforward change to fix the issue. Is it possible the following TS change can be reverted?

As metioned in TS 4.8 release notes linked above, T is no longer assignable to {} so it's no longer valid in ts 4.8.X because T no longer constraints ObjectLiteral.

[andrewbranch]

I fixed all the typeorm errors when the change first landed, and it was very straightforward: typeorm/typeorm#9106. I guess new changes to typeorm were introduced in the meantime. They should be able to follow the same pattern and fix the new ones. I can try to send a follow-up PR tomorrow if they don’t get to it first. But no, the TS change will definitely not be reverted. The error is accurate and protects against real unsafe calls.