Import for `IDisposable` is no longer suggested

[bpasero]

TS Template added by @mjbvz

TypeScript Version: 4.6.0-dev.20220206

Search Terms

• auto import
• suggest / suggestions
• completions

Repro

1. In the VS Code codebase
2. Open a file such as codeActionContributions.ts
3. Try triggering suggestions for IDisposable

---

I am not sure if this is an issue with the UI or a TS issue, I no longer see IDisposable being suggested in the suggest widget, only in the quick fix:

[mjbvz]

This seems to cause the following exception in my testing:

Debug Failure. False expression.
Error: Debug Failure. False expression.
    at getCompletionEntryCodeActionsAndSourceDisplay (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:129606:22)
    at Object.getCompletionEntryDetails (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:129549:30)
    at Object.getCompletionEntryDetails (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:160610:35)
    at Object.proxy.<computed> [as getCompletionEntryDetails] (/Users/matb/projects/vscode/node_modules/tsec/lib/utils.js:28:45)
    at /Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:172138:57
    at Object.mapDefined (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:599:30)
    at IpcIOSession.Session.getCompletionEntryDetails (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:172136:33)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:170958:61)
    at /Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:172756:88
    at IpcIOSession.Session.executeWithRequestId (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:172747:28)
    at IpcIOSession.Session.executeCommand (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:172756:33)
    at IpcIOSession.Session.onMessage (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:172782:35)
    at process.<anonymous> (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:175417:31)
    at process.emit (events.js:315:20)
    at emit (internal/child_process.js:903:12)
    at processTicksAndRejections (internal/process/task_queues.js:81:21): Error: <semantic> TypeScript Server Error (4.6.0-dev.20220110)

[mjbvz]

Actually that may be unrelated. I suspect that the root cause is that IDisposable happens to be re-exported from another file even through it is primarily consumed through the original file:

https://github.com/microsoft/vscode/blob/84163149f3aa4f57b4407199cae52af18f0d8269/src/vs/workbench/workbench.web.main.ts#L196

[andrewbranch]

@mjbvz is correct—we only offer one auto import per "target symbol" in completion lists to avoid massively cluttering the list when you have a series of barrels. The one we chose was chosen because it has fewer slashes than the other. I don’t think we’re looking to change this behavior in general at the moment (there is an open suggestion for it somewhere I think), but in the particular example you provided, there was already an existing import from vs/base/common/lifecycle, which should make it the top priority import. (In fact, when you trigger the code fix menu, you see we don’t offer to import it from vs/workbench/workbench.web.main because we understand updating an existing import to be far superior to adding a new one.) I’ll double check that it’s not a big perf cost to do the same thing in completions, but I think that should be doable.