Completions crash with AMD + Classic + rooted rootDirs entry

[qxo]

        return str.lastIndexOf(prefix, 0) === 0;
                   ^
TypeError: Cannot read properties of undefined (reading 'lastIndexOf')
    at Object.startsWith (D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:1695:20)
    at isPathRelativeToParent (D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:96841:23)
    at D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:96797:24
    at Object.firstDefined (D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:158:26)
    at getPathRelativeToRootDirs (D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:96795:23)
    at tryGetModuleNameFromRootDirs (D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:96654:40)
    at getLocalModuleSpecifier (D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:96422:44)
    at computeModuleSpecifiers (D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:96400:33)
    at getModuleSpecifiersWithCacheInfo (D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:96368:26)
    at Object.getModuleSpecifiers (D:\_bazel_admin\zdx3yfxt\execroot\ankidesktop\node_modules\typescript\lib\tsc.js:96353:20)
Target //:dist failed to build

===>

TypeScript/src/compiler/core.ts

Line 2138 in 2ce05a8

return str.lastIndexOf(prefix, 0) === 0;

[DanielRosenwasser]

Hi, would you be able to provide more detail on how you got this error (including content requested in the original issue template)? This looks like a duplicate of #37531 which should be fixed.

[DanielRosenwasser]

TypeScript/src/compiler/moduleSpecifiers.ts

Line 857 in 0f1496f

const relativePath = getRelativePathIfInDirectory(path, rootDir, getCanonicalFileName)!; // TODO: GH#18217

Is likely the culprit, which springs up when you have a rooted disk path as a rootDir.

TypeScript/src/compiler/moduleSpecifiers.ts

Line 909 in 0f1496f

return isRootedDiskPath(relativePath) ? undefined : relativePath;

[DanielRosenwasser]

Minimal repro

// tsconfig.json
{
    "compilerOptions": {
        "module": "amd",
        "moduleResolution": "classic",
        "strict": true,
        "outDir": "../out",
        "rootDirs": ["D:/"]
    },
    "files": [
        "./foo.ts"
    ]
}

// ./foo.ts
/**/

Request completions at /**/.

TypeError: Cannot read property 'lastIndexOf' of undefined
    at Object.startsWith ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:2057:20)
    at isPathRelativeToParent ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:119695:23)
    at [USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:119641:24
    at Object.firstDefined ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:207:26)
    at getPathRelativeToRootDirs ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:119639:23)
    at tryGetModuleNameFromRootDirs ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:119457:40)
    at getLocalModuleSpecifier ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:119115:44)
    at computeModuleSpecifiers ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:119083:33)
    at Object.getModuleSpecifiersWithCacheInfo ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:119043:26)
    at getModuleSpecifiers ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:148875:81)
    at [USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:148879:26
    at Object.flatMap ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:502:25)
    at getNewImportFixes ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:148877:28)
    at Object.getModuleSpecifierForBestExportInfo ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:148694:22)
    at Object.tryResolve ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:128427:34)
    at [USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:130129:46
    at [USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:126080:21
    at Map.forEach (<anonymous>)
    at Object.forEach ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:126078:28)
    at [USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:130111:32
    at resolvingModuleSpecifiers ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:128410:26)
    at collectAutoImports ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:130110:17)
    at getGlobalCompletions ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:130015:17)
    at tryGetGlobalSymbols ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:129921:25)
    at getCompletionData ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:129674:22)
    at Object.getCompletionsAtPosition ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:128474:34)
    at Object.getCompletionsAtPosition ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:160304:35)
    at IOSession.Session.getCompletions ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:171774:64)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:170619:61)
    at [USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:172423:88
    at IOSession.Session.executeWithRequestId ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:172414:28)
    at IOSession.Session.executeCommand ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:172423:33)
    at IOSession.Session.onMessage ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:172449:35)
    at Interface.<anonymous> ([USERDIR]\scratch\example\node_modules\typescript\lib\tsserver.js:175054:31)
    at Interface.emit (events.js:315:20)
    at Interface._onLine (readline.js:337:10)
    at Interface._normalWrite (readline.js:482:12)
    at Socket.ondata (readline.js:194:10)
    at Socket.emit (events.js:315:20)
    at addChunk (internal/streams/readable.js:309:12)
    at readableAddChunk (internal/streams/readable.js:284:9)
    at Socket.Readable.push (internal/streams/readable.js:223:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)

[DanielRosenwasser]

I'm having a hard time making this work in fourslash.

This doesn't trigger any crash:

/// <reference path="./fourslash.ts" />

// @module: amd
// @moduleResolution: classic
// @rootDirs: D:/
// @Filename: C:/proj/src/bar.ts
//// /*$*/


verify.completions({
    marker: "$"
});

And this one has other issues - fourslash says it can't find the file in question (Error: Could not find source file: 'C:/proj/src/bar.ts'.).

/// <reference path="./fourslash.ts" />

// @Filename: C:/proj/src/tsconfig.json
////{
////    "compilerOptions": {
////        "module": "amd",
////        "moduleResolution": "classic",
////        "rootDirs": ["D:/"]
////    },
////    "include": ["./**/*"]
////}

// @Filename: C:/proj/src/foo.ts
//// export function foo() {}

// @Filename: C:/proj/src/bar.ts
//// /*$*/

verify.completions({
    marker: "$",
    includes: {
        name: "foo",
    }
});