Inlay Hint for TypeScript broken for spread operation

[justinfernald]

TS Template added by @mjbvz

TypeScript Version: 4.5.4

Search Terms

• inlay hints
• provideInlayHints

---

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.63.2
• OS Version: Windows_NT x64 10.0.22000

Steps to Reproduce:

1. build function that takes in multiple parameters (3 minimum to view issue)
2. call function with spread tuple (2 elements minimum) first, then fill in remaining arguments.
3. it will then be offset since the spread tuple will only count as a single argument

Notice that in the screenshot the x and y arguments should be in both be handled from the spread, however, the spread is just the x argument.

[mjbvz]

Please share a minimal code example (as text) that demonstrates the issue

[willgarrett610]

If the TypeScript › Inlay Hints › Parameter Names setting is set as all, the argument labels while calling the example function are incorrect. This is because x and y are spread but vscode thinks the spread is one argument.

function example(x: number, y: number, a: number, b: number) {
  return x + y + a + b;
}

const point: [x: number, y: number] = [1, 2];

example(...point, 3, 4);

In this example, ...point should be labeled as x and y. 3 and 4 would be a and b respectively.