Skip to content

Please share large source lines when possible #45849

Closed
@SnarkBoojum

Description

@SnarkBoojum

While packaging 4.4.3 for Debian, the tools complained:

E: node-typescript source: source-is-missing lib/tsc.js line 100216 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/tsserver.js line 148247 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/tsserverlibrary.js line 147421 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/typescript.js line 138426 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/typescriptServices.js line 138426 is 9536 characters long (>512)
E: node-typescript source: source-is-missing lib/typingsInstaller.js line 103440 is 9536 characters long (>512)

and in fact, the problem is with unicodeES3Identifier* variables: it is legitimate source code, but indeed looks suspicious.

I suggest to share those variables instead of copying them in several source files: that will be much safer in the long run.

Metadata

Metadata

Assignees

No one assigned

    Labels

    UnactionableThere isn't something we can do with this issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions