Missing autocomplete on the "abstract" keyword

[pushkine]

Bug Report

🕗 Version & Regression Information

ts stable & nightly

⏯ Playground Link

Playground Link

💻 Code

export class Foo {}

[heyAyushh]

@DanielRosenwasser I want to work on this.
How do I get started?

[DanielRosenwasser]

The fix will likely start in src/services/completions.ts and you should start with a failing test in tests/cases/fourslash/.

[fabioemoutinho]

is this related?
#34491
#32474

[sourabh112]

Hi @DanielRosenwasser, I would like to work on this issue if no one else is working on it. As I'm quite new to this, I might need your guidance for a lot of things.

[DanielRosenwasser]

If @heyAyushh isn't still working on this, go for it, but I would encourage you to explore/familiarize yourself with the surrounding code I've pointed out above, and look to those PRs to get a sense of what sort of work this change might involve. If you get it working, I or someone else on the team can provide code review feedback.

[heyAyushh]

Yes @DanielRosenwasser , I haven't started contributing as I am exploring typescript source code right now.
If there's a resource let me know.

I also didn't have the resources for testing docker.

[DanielRosenwasser]

You don't need to use Docker to contribute, using a container is just an option if you find that helpful.

[sourabh112]

@DanielRosenwasser, I was looking at the code of file src/services/completions.ts. and found this piece of code.

TypeScript/src/services/completions.ts

Lines 3015 to 3028 in 59b8bef

	function isClassMemberCompletionKeyword(kind: SyntaxKind) {
	switch (kind) {
	case SyntaxKind.AbstractKeyword:
	case SyntaxKind.ConstructorKeyword:
	case SyntaxKind.GetKeyword:
	case SyntaxKind.SetKeyword:
	case SyntaxKind.AsyncKeyword:
	case SyntaxKind.DeclareKeyword:
	case SyntaxKind.OverrideKeyword:
	return true;
	default:
	return isClassMemberModifier(kind);
	}
	}

I think Abstractkeyword should not be placed here because it can be used anywhere not only in classes. So, I was thinking of removing it from here and adding it places for global completion following #34491. Then I will run the test on tests/cases/fourslash/ and make changes if needed.

Please confirm, If I'm going in the right direction. If not then please correct me, As it is my first time working on TypeScript.