Skip to content

Go-to-def on override should navigate to the overridden methodΒ #44736

Closed
@uniqueiniquity

Description

@uniqueiniquity

Suggestion

πŸ” Search Terms

override, definition

βœ… Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

When writing an overriding method, I want to be able to easily jump to the method that I'm overriding for several reasons (making sure I'm doing it right, viewing implementation differences, etc). Right now, in VS Code, I have to go-to-def on the method name, which shows me all references and other implementations of the method from other subclasses.

It seems like a good way to arrange this would be to have go-to-def requests that are triggered on the override keyword to have this behavior. I haven't fully thought through whether there might be a case where you'd have several targets, but it seems reasonable to just provide all of them for the editor to manifest how they wish.

I actually expected this to work because this is the behavior for override in C# in VS.

πŸ“ƒ Motivating Example

See above.

πŸ’» Use Cases

See above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions