Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: mode for --build to keep going after a project fails #42739

Open
5 tasks done
lencioni opened this issue Feb 10, 2021 · 0 comments
Open
5 tasks done

Feature request: mode for --build to keep going after a project fails #42739

lencioni opened this issue Feb 10, 2021 · 0 comments
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript

Comments

@lencioni
Copy link

Suggestion

πŸ” Search Terms

build
keep going
bail
fail fast
project references
large monorepo
-b

#25600
#32651

βœ… Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

It would be nice if there was a way to configure TypeScript --build to try to keep building projects after encountering an error anyway, so that it will continue to build all of the projects regardless of any errors, so more errors in more projects could be seen at one time.

πŸ“ƒ Motivating Example

I work in a fairly large monorepo where we have set up project references for all of our projects. We currently have about 80,000 TypeScript files spread out amongst ~1,000 projects. The project dependency graph is fairly tight, with many of these projects sharing many upstream projects as dependencies.

One pain point we've encountered is when making a change to a project that many other projects depend on (or when updating TypeScript or a widely-used package or @types package) is that:

a) A complete TypeScript --build takes a lot of time to run.
b) Our TypeScript --build stops after finding the first set of failures.

This combination makes the feedback loop really slow and painful as we repeatedly have to run the slow build in order to uncover all of the issues to fix or add @ts-expect-error comments.

πŸ’» Use Cases

  • Making changes to types in projects that cause errors in many other projects
  • Updating TypeScript versions
  • Updating packages

Currently, any of these tasks requires slow feedback loops that can make the work drag on for hours since only a handful of projects can be fixed at a time. We are currently doing this by fixing the few projects that TypeScript shows us errors for, and then starting the build again, waiting for it to get farther, and repeating until the build fully passes.

@RyanCavanaugh RyanCavanaugh added In Discussion Not yet reached consensus Suggestion An idea for TypeScript labels Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

2 participants