You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's been a bit of work invested from the VS Code team to implement semantic highlighting for TS/JS code in a reasonable efficient way. We want to see if there's a reasonable level of support that doesn't accidentally incur a full-program type-check.
Based on what Orta Therox (@orta) said, the first item appears to be in there now, the second is not:
Semantic Highlight for TS = 'a class is highlighted differently from an object'
Semantic Highlight from your blog post is 'a const object called a is a different color from a const object called b'
Orta Therox (@orta) I don't mind building the second solution myself; in fact, I've tried a few times, but I don't see anything in VS Code that lets me grab the words during syntax highlighting. Is there any way I could manually "parse the DOM" and replace the colors myself?
I think you'd need vscode team buy-in and an extension API for that - this issue is specifically about the first bit, which did ship. I left the issue open because #40949 is really something I should go back to and try merge, but the feature itself did ship in 4.1
This should have been closed by #39119 as far as I can tell. That PR says it’s part 1 of 2 but I’m not sure what part 2 was supposed to be, but it seems like it would have been asked for sometime in the last couple years if it still needed to be done.
Activity
orta commentedon May 12, 2020
10 remaining items
MartinJohns commentedon Jul 2, 2021
This feature should probably be removed from the 4.1 release on the roadmap.
DanielRosenwasser commentedon Sep 8, 2021
Was this not implemented by #42438 for 4.1?
Sawtaytoes commentedon Sep 8, 2021
Based on what Orta Therox (@orta) said, the first item appears to be in there now, the second is not:
Orta Therox (@orta) I don't mind building the second solution myself; in fact, I've tried a few times, but I don't see anything in VS Code that lets me grab the words during syntax highlighting. Is there any way I could manually "parse the DOM" and replace the colors myself?
orta commentedon Sep 8, 2021
I think you'd need vscode team buy-in and an extension API for that - this issue is specifically about the first bit, which did ship. I left the issue open because #40949 is really something I should go back to and try merge, but the feature itself did ship in 4.1
Sawtaytoes commentedon Sep 8, 2021
Orta Therox (@orta) Thanks for the suggestion: microsoft/vscode#132689.
andrewbranch commentedon Mar 22, 2022
This should have been closed by #39119 as far as I can tell. That PR says it’s part 1 of 2 but I’m not sure what part 2 was supposed to be, but it seems like it would have been asked for sometime in the last couple years if it still needed to be done.