VSCode intellisense not working with typescript 3.7.5 in Angular projects

[admosity]

TS Template added by @mjbvz

TypeScript Version: 3.7.5

Search Terms

• angular

---

Using the latest vscode with Typescript 3.7.5, intellisense breaks for anything referencing node_modules. This is reflected on new projects created with @angular/cli as well. Tested on an Angular 7 project to see if the version difference between Angular 7 and Angular 9 made a difference.

> code --version
1.42.1
c47d83b293181d9be64f27ff093689e8e7aed054
x64

Steps to Reproduce:

1. Type a symbol that can be indexed from node_modules (e.g. ReactiveFormsModule from Angular).
2. Hit ctrl+space or whatever is the intellisense hotkey is configured..
3. No Suggestions appears.

Switching to the lower workspace Typescript version in my Angular 7 setup I can get the suggestions to show again.

Video reproduction with Typescript version switch:

On a fresh Angular 9 setup:

Does this issue occur when all extensions are disabled?: Yes

Same project in Atom:

EDIT: This appears to be happening in Atom with Typescript 3.7.5 as well now in the Angular 9 setup. Might be specifically a Typescript 3.7.5 issue.

EDIT EDIT: It seems that adding node_modules/@angular as a typeRoot fixes some issues:

TSCONFIG:

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "downlevelIteration": true,
    "experimentalDecorators": true,
    "module": "esnext",
    "moduleResolution": "node",
    "importHelpers": true,
    "target": "es2015",
    "typeRoots": [
      "node_modules/@types",
      "node_modules/@angular"
    ],
    "lib": [
      "es2018",
      "dom"
    ]
  },
  "angularCompilerOptions": {
    "fullTemplateTypeCheck": true,
    "strictInjectionParameters": true
  }
}

It seems that adding node_modules/@angular as a typeRoot fixes some issues:

[mjbvz]

Does it work as expected with Ts 3.8? I believe they fixed a few bugs related to newer angular versions in that release

[admosity]

Same result with 3.8:

[admosity]

I pushed up the setup that was generated by angular's cli tool:

https://github.com/admosity/angular-9-vscode-intellisense

Maybe it could just be me...

[DanielRosenwasser]

Verified in 3.9.0-dev.20200303

[DanielRosenwasser]

Ideally typeRoots shouldn't need to be specified at all here. I'm not sure if Angular CLI itself does that at all. (@mgechev)

[mgechev]

FYI angular/angular-cli#17149.

[andrewbranch]

Duplicate of #36042 (canonical), #30033, #30474, and #28773.