JsxAttributes - Add `kind` property

[dsherret]

Search Terms

JsxAttributes kind

Suggestion

Change:

export interface JsxAttributes extends ObjectLiteralExpressionBase<JsxAttributeLike> {
    parent: JsxOpeningLikeElement;
}

To:

export interface JsxAttributes extends ObjectLiteralExpressionBase<JsxAttributeLike> {
    kind: SyntaxKind.JsxAttributes;
    parent: JsxOpeningLikeElement;
}

Use Cases

Would help when people are narrowing down types while using the compiler api.

In my case, I'm analyzing nodes in the compiler and it couldn't figure out the kind of JsxAttributes. So I hardcoded a condition right now to properly return the kind.

Checklist

My suggestion meets these guidelines:

• This wouldn't be a breaking change in existing TypeScript/JavaScript code
• This wouldn't change the runtime behavior of existing JavaScript code
• This could be implemented without emitting different JS based on the types of the expressions
• This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
• This feature would agree with the rest of TypeScript's Design Goals.

[dsherret]

Let me know if this is what it should be and I'll submit a PR.

[sandersn]

Seems right, and it builds. @weswigham, can you confirm?

[weswigham]

Looks right - surprised it was missing; guess we never use it in a union anywhere. 🤷‍♂