Can't use auto import when node_modules are named "node_modules"

[lukeurban]

• VSCode Version: 1.30.2 (1.30.2)
• OS Version: macOS Mojave 10.14.2

Steps to Reproduce:

1. Create new angular project using CLI
2. Install dependencies
3. Try to import module (eg. HttpClientModule)

Then no auto import is available. BUT!! if I change name from node_modules/ to node_modules2/ then everything is fine. I've tried few "fixes" with no success.
Screens

Does this issue occur when all extensions are disabled?: Yes

[mjbvz]

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

[Prestini]

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

Same thing here on Insiders also

[saulgill]

I also have this issue. I can confirm that changing the name of "node_modules" to "node_modules2" fixes the issue. Is there another fix that does not require this change?

[mjbvz]

I confirmed this using TS 3.3-rc and a new angular app created from the CLI.

HttpClientModule is defined in @angular/common/http. Manually adding this import works but I don't see where the http.d.ts typings are exported in the @angular/common package's main index.d.ts

[aleclarson]

This issue provides a repro: microsoft/vscode#67505

[aleclarson]

Probably related: #29039

[andrewbranch]

The reason renaming the node_modules folder works is that the default value of exclude in tsconfig.json includes "node_modules". The practical effect of this is that TypeScript doesn’t know about anything inside node_modules until you import something in there—this is by design. (See #28773.)

It’s possible that’s what’s happening, but there’s not enough information here to know for sure yet. To test that theory, can you try adding an import "@angular/common/http"; anywhere in your project? If, after that, auto-import for HttpClientModule works, then this is working as intended. If it doesn’t, then this is a bug.

[andrewbranch]

To test that theory, can you try adding an import "@angular/common/http"; anywhere in your project? If, after that, auto-import for HttpClientModule works, then this is working as intended. If it doesn’t, then this is a bug.

I just did this myself, and the auto-import for HttpClientModule shows up, which makes this expected behavior, and a duplicate of #30033 and #28773.

I will note, though, that despite our current stance that this is a “working as intended,” we are paying attention to the fact that users are frequently confused by this behavior and/or request that the behavior change, and I’m brainstorming ways to make the experience better. Just can’t promise anything specific yet.