"Move to new file" does not copy React import

[OliverJAsh]

TypeScript Version: 3.1.3

Search Terms: react umd "move to new file" refactor

Code

// ./src/index.tsx
import * as React from 'react';

const MyComponent: React.SFC<{}> = props => <div />;

export default MyComponent;

{
    "compilerOptions": {
        "jsx": "react"
    },
    "include": ["./src/**/*"]
}

Expected behavior:
When copying the line const MyComponent and actioning the "Move to new file" command, the new file contents should be:

import * as React from 'react';
export const MyComponent: React.SFC<{}> = props => <div />;

Actual behavior:
The new file contents are:

export const MyComponent: React.SFC<{}> = props => <div />;

The React import is missing, which creates errors:

// React import is missing…
export const MyComponent: SFC<{}> = props =>
  // … which results in error: 'React' refers to a UMD global, but the current file is a module. Consider adding an import instead.
  <div />;

[amcasey]

I think we had some related issues in Organize Imports where he had to force React imports specifically (vs all UMD) to be treated as used because we were getting false negatives.

[amcasey]

Specifically, we probably need something like this

https://github.com/Microsoft/TypeScript/blob/aa3734c14834afb454c49bc956489980d990a765/src/services/organizeImports.ts#L137

here

https://github.com/Microsoft/TypeScript/blob/afbf89e3b3983fef4dfb5487556b374039e2744e/src/services/refactors/moveToNewFile.ts#L458

[amcasey]

Fixed by #29451.

[mizchi]

@amcasey

Original issue is fixed, but I encountered next other reference error.

before

// index.tsx
import React from 'react';
<div />
/* extract start */
function App() { return <div /> }
/* extract end */

after

// index.tsx
<div /> // React reference error

[OliverJAsh]

@mizchi See #27937

[amcasey]

@OliverJAsh - it looks like you might have linked to the current issue. Did you mean to link to a different one?

[OliverJAsh]

Nope sorry I was confused. Ignore that comment