Different definition behavior for import vs require

[mjbvz]

From microsoft/vscode#48820

TypeScript Version: 2.9.0-dev.20180427

Search Terms:

• definition
• javascript

Code
For the project:

base.js

module.exports = class Base {
	constructor() {
		console.log( "base" );
	}
}

foo.js

const Base = require( "./base" );

class Foo extends Base {
	bar() {
		const base      = new Base();
		const BaseClass = Base;
	}
}

1. Run go to definition on Base in new Base() in foo

Expected behavior:
Goes to class Base in bar.js

Actual behavior:
Goes to require. If you use an import, we navigate to the class itself instead of to the import

[mhegazy]

Seems working in typescript@next. VSCode ships with an older version of TypeScript. Please see Using Newer TypeScript Versions documentation for more details on updating your VSCode to use a different version of TypeScript.

[mjbvz]

@mhegazy I still see this in 2.9.0-dev.20180427:

[Trace  - 14:52:29] Sending request: definition (171). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "/Users/matb/projects/san/foo.js",
    "line": 5,
    "offset": 21
}
[Trace  - 14:52:29] Response received: definition (171). Request took 1 ms. Success: true 
Result: [
    {
        "file": "/Users/matb/projects/san/foo.js",
        "start": {
            "line": 2,
            "offset": 7
        },
        "end": {
            "line": 2,
            "offset": 11
        }
    }
]

[mhegazy]

this is what i see locally, what am i missing?

[Trace  - 3:08:51 PM] Sending request: definition (249). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "c:/test/23742/foo.js",
    "line": 5,
    "offset": 28
}
[Trace  - 3:08:51 PM] Response received: definition (249). Request took 5 ms. Success: true 
Result: [
    {
        "file": "c:/test/23742/base.js",
        "start": {
            "line": 2,
            "offset": 2
        },
        "end": {
            "line": 4,
            "offset": 3
        }
    }
]

[mjbvz]

Are you on a build from master or the latest TS insiders build?

For Base in extends Base, I see:

[Trace  - 15:22:06] Sending request: definition (51). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "/Users/matb/projects/san/foo.js",
    "line": 3,
    "offset": 20
}
[Trace  - 15:22:06] Response received: definition (51). Request took 1 ms. Success: true 
Result: [
    {
        "file": "/Users/matb/projects/san/foo.js",
        "start": {
            "line": 1,
            "offset": 7
        },
        "end": {
            "line": 1,
            "offset": 11
        }
    }
]

And for Base in new Base(), I see:

[Trace  - 15:21:19] Response received: definition (45). Request took 3 ms. Success: true 
Result: [
    {
        "file": "/Users/matb/projects/san/base.js",
        "start": {
            "line": 2,
            "offset": 5
        },
        "end": {
            "line": 4,
            "offset": 6
        }
    },
    {
        "file": "/Users/matb/projects/san/foo.js",
        "start": {
            "line": 1,
            "offset": 7
        },
        "end": {
            "line": 1,
            "offset": 11
        }
    }
]

[mhegazy]

I was looking at an older build. the behavior you are seeing is caused by #23657, where we are returning both declarations. i think in this case we should not return the alias.

I think @sandersn was working on making const x = require("x") an alias, similar to #23570?

[sandersn]

We should keep this bug open, because the next alias I planned to introduce was for module.exports.C = class { } (tracked by #23788), not for const x = require('x').