TypeScript 1.4 indentation issue on chained function calls

[basarat]

Before we would have:

var doSomethingThatReturnsAPromise: any;
this.doSomethingThatReturnsAPromise()
    .then(() => {
        // more code
    })
    .then(() => {
        // even more code
    });

Now we have

var doSomethingThatReturnsAPromise: any;
this.doSomethingThatReturnsAPromise()
    .then(() => {
    // more code
})
    .then(() => {
    // even more code
});

Raised from SO

[giuseppelt]

+1

[mhov]

It's even worse when you use the errorCallback of promise.then(...) and/or finally()

this.somethingWithAPromise()
    .then(() => {
    // more code
},
    (reason) => {
        // more code
    })
    .finally(() => {
    // more code
});

Can this please be moved back to Milestone 1.5? This is a real minute-by-minute hassle.

[Anupheaus]

I have to agree, it is making the code look far more difficult to read and follow than it really needs to be.

[danquirk]

@mhegazy @vladima how much work is it to fix this? Can we get it in 1.5?

[NoelAbrahams]

Not to mention all the unnecessary diffs that will occur after this is fixed. So sooner the better.

[mhegazy]

PRs are always welcomed :)

Seems like a fairly exacting repair - even if someone submitted a fix, how could they or you be confident that it didn't make other formatting scenarios break? I'd be more willing to look into it if internal developers gave notes/guidance on what files/area of the project need to be considered, possibly including unit tests it needs to pass and how to run them. I guess it depends on which would be more work.

[basarat]

A recent example of a test : https://github.com/Microsoft/TypeScript/pull/2108/files#diff-1437e63151cc8482fc0ffc4f1d0fc3ddR2

If the tests pass. It hasn't broken old stuff (hopefully) 👍

[cwmacdon]

Another instance of TS 1.4 changed code format behaviour:
It is removing the space after the first parameter in _.each

TS 1.3:

_.each(foo, (bar: string): void => {
    // code
});

TS 1.4

_.each(foo,(bar: string): void => {
    // code
});

[basarat]

@cwmacdon perhaps (https://github.com/TypeStrong/atom-typescript/blob/master/docs/tsconfig.md#formatcodeoptions) insertSpaceAfterCommaDelimiter: true?