Extract function doesn't respect indentation settings

[mjbvz]

From @dbaeumer on August 30, 2017 8:35

Testing: #33282

function foo() {
	console.log('Hello World');
}

• observe: console.log is indented using tabs
• select console.log('Hello World');
• run extract function
• you get

function foo() {
    newFunction();
}
function newFunction() {
    console.log('Hello World');
}

Observe: spaces are used as indentation.

Copied from original issue: microsoft/vscode#33492

[mjbvz]

From @dbaeumer on August 30, 2017 8:36

@mjbvz unclear if this is us or TS

[mjbvz]

After investigating this, it does seem like this should be fixed on the TS side. We send the correct formatting configuration

[mhegazy]

For repro purposes, make sure editor.insertSpaces is false in the vscode settings; this should set the server format config convertTabsToSpaces to false.

looks like we are not using the correct format settings when we get the refactor edits

[DanielRosenwasser]

@bterlson also ran into this with 2 spaces vs 4 spaces.