URLSearchParams constructor argument should be `string | object`

[saschanaz]

TypeScript Version: 2.2.1 / nightly (2.2.0-dev.201xxxxx)

Code

By the spec:

let params = new URLSearchParams({key: "730d67"})
params.toString() // "key=730d67"

Expected behavior:

The example should work.

Actual behavior:

Error: Argument of type '{ key: string }' is not assignable to parameter of type 'string | URLSearchParams`

[mhegazy]

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

in the spec you linked:

[Constructor(optional (sequence<sequence<USVString>> or record<USVString, USVString> or USVString) init = ""), Exposed=(Window,Worker)]

you're forgetting the sequence<sequence<USVString>> part

i think the type should be [string, string][] | {[key: string]: string} | string

that way these would work:

new URLSearchParams([
	["key", "value"]
]);

new URLSearchParams({
	key: "value"
});

and these wouldn't:

// no value
new URLSearchParams([
	["key"]
]);

// the value should be a string because it's converted to one
new URLSearchParams({
	key: 123
});

// ???
new URLSearchParams(URLSearchParams);

i am just a fan of getting things right

[kgtkr]

This issue has not been fixed in version 2.6