TSServer 'references' only Works if Target Location is in property name

[mjbvz]

Needed for microsoft/vscode#18205

TypeScript Version: 2.2.0-dev.20170104

class Foo {
    public abc;
}

var foo = new Foo()
foo.abc = 10

I'm trying to execute a references request against the TSServer for the property abc. Currently, this only works if the target location is somewhere within the string abc. I believe the references command should work if the target location is anywhere inside of public abc instead.

This blocks adopting a references code lens provider in VSCode. The problem is that when determining which symbols in the document we want to have show reference counts for, the navtree request for the document returns abc with the entire public abc span. This span does not work with the references request that we later fire off.

[mjbvz]

Another example is getters and setters:

class Foo {
    get prop() { return 2}
    set prop(x: number) { }
}

The location for references currently can only be inside the string prop, not get prop or set prop

[mjbvz]

@waderyan FYI

We could try working around this on the VSCode side but the TypeScript server seems much better suited to handling this since it should already have all to information about the document. These same cases also all impact the current Find all references command in VSCode.

[mjbvz]

Sorry for the spam but a few more cases:

class Foo {
    static bla() { }
}

interface Foo {}

type Foo = number;

All must be inside the name itself and not in class or interface or static or type

[mhegazy]

@mjbvz is this still an issue?

[mjbvz]

Yes, I just tested this on 2.5.1 and on 2.6 and still see this issue

@mjbvz This seems to be working in vscode right now, is that because workarounds were added? Should we still implement this functionality in tsserver so the workarounds can be removed?

[mjbvz]

Yes I added some workarounds for this, for example: https://github.com/Microsoft/vscode/blob/3a14fde91d1fd0b3060b9eefb0780dd8d8b80e18/extensions/typescript-language-features/src/features/baseCodeLensProvider.ts#L129