Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Introduce .gitattributes file"
This reverts commit 218064d.
- Loading branch information
This reverts commit 218064d.
e179e05There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielRosenwasser why was this commit reverted?
e179e05There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jedmao after the change a lot of files that did not have the correct file endings were force edited for everybody. we reverted the change to look at these files, fix them then reapply the change.
e179e05There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Git automatically fixes the line endings, what is it that you are trying to fix manually? You can't get away from it. This commit will force consistent line endings, but once it's in place, it will ensure inconsistent line endings aren't reintroduced. I might be able to submit a different PR with that step already done.
e179e05There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests should have their own .gitattributes, this way we can have a test that have a different line ending. @DanielRosenwasser is looking into it.
e179e05There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhegazy @DanielRosenwasser I'll defer to your experience with which tests should have these files, but yes, you can do that by either creating a
.gitattributesfile in the test folder or adding it to the root, like so:Hope that helps!