Skip to content

Commit b601487

Browse files
author
Micah Zoltu
authored
Updates Uint8ArrayConstructor to match MDN documentation. (#38449)
* Updates Uint8ArrayConstructor to match MDN documentation. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/Uint8Array ``` new Uint8Array(); // new in ES2017 new Uint8Array(length); new Uint8Array(typedArray); new Uint8Array(object); new Uint8Array(buffer [, byteOffset [, length]]); ``` While the previous constructors aren't significantly different from the new, it would prevent someone from doing `new Uint8Array(myBuffer, undefined, undefined)` since there was no overload that accepted undefined as a second parameter and buffer as first. Fixes #38446 * Fixes constructor defenition for all other typed arrays. * Renames property to `array` since it is no longer an `arrayOrBuffer`.
1 parent bae111f commit b601487

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

src/lib/es5.d.ts

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1946,8 +1946,8 @@ interface Int8Array {
19461946
interface Int8ArrayConstructor {
19471947
readonly prototype: Int8Array;
19481948
new(length: number): Int8Array;
1949-
new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Int8Array;
1950-
new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Int8Array;
1949+
new(array: ArrayLike<number>): Int8Array;
1950+
new(buffer: ArrayBufferLike, byteOffset?: number, length?: number): Int8Array;
19511951

19521952
/**
19531953
* The size in bytes of each element in the array.
@@ -2229,8 +2229,8 @@ interface Uint8Array {
22292229
interface Uint8ArrayConstructor {
22302230
readonly prototype: Uint8Array;
22312231
new(length: number): Uint8Array;
2232-
new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Uint8Array;
2233-
new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Uint8Array;
2232+
new(array: ArrayLike<number>): Uint8Array;
2233+
new(buffer: ArrayBufferLike, byteOffset?: number, length?: number): Uint8Array;
22342234

22352235
/**
22362236
* The size in bytes of each element in the array.
@@ -2511,8 +2511,8 @@ interface Uint8ClampedArray {
25112511
interface Uint8ClampedArrayConstructor {
25122512
readonly prototype: Uint8ClampedArray;
25132513
new(length: number): Uint8ClampedArray;
2514-
new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Uint8ClampedArray;
2515-
new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Uint8ClampedArray;
2514+
new(array: ArrayLike<number>): Uint8ClampedArray;
2515+
new(buffer: ArrayBufferLike, byteOffset?: number, length?: number): Uint8ClampedArray;
25162516

25172517
/**
25182518
* The size in bytes of each element in the array.
@@ -2791,8 +2791,8 @@ interface Int16Array {
27912791
interface Int16ArrayConstructor {
27922792
readonly prototype: Int16Array;
27932793
new(length: number): Int16Array;
2794-
new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Int16Array;
2795-
new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Int16Array;
2794+
new(array: ArrayLike<number>): Int16Array;
2795+
new(buffer: ArrayBufferLike, byteOffset?: number, length?: number): Int16Array;
27962796

27972797
/**
27982798
* The size in bytes of each element in the array.
@@ -3074,8 +3074,8 @@ interface Uint16Array {
30743074
interface Uint16ArrayConstructor {
30753075
readonly prototype: Uint16Array;
30763076
new(length: number): Uint16Array;
3077-
new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Uint16Array;
3078-
new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Uint16Array;
3077+
new(array: ArrayLike<number>): Uint16Array;
3078+
new(buffer: ArrayBufferLike, byteOffset?: number, length?: number): Uint16Array;
30793079

30803080
/**
30813081
* The size in bytes of each element in the array.
@@ -3356,8 +3356,8 @@ interface Int32Array {
33563356
interface Int32ArrayConstructor {
33573357
readonly prototype: Int32Array;
33583358
new(length: number): Int32Array;
3359-
new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Int32Array;
3360-
new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Int32Array;
3359+
new(array: ArrayLike<number>): Int32Array;
3360+
new(buffer: ArrayBufferLike, byteOffset?: number, length?: number): Int32Array;
33613361

33623362
/**
33633363
* The size in bytes of each element in the array.
@@ -3637,8 +3637,8 @@ interface Uint32Array {
36373637
interface Uint32ArrayConstructor {
36383638
readonly prototype: Uint32Array;
36393639
new(length: number): Uint32Array;
3640-
new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Uint32Array;
3641-
new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Uint32Array;
3640+
new(array: ArrayLike<number>): Uint32Array;
3641+
new(buffer: ArrayBufferLike, byteOffset?: number, length?: number): Uint32Array;
36423642

36433643
/**
36443644
* The size in bytes of each element in the array.
@@ -3919,8 +3919,8 @@ interface Float32Array {
39193919
interface Float32ArrayConstructor {
39203920
readonly prototype: Float32Array;
39213921
new(length: number): Float32Array;
3922-
new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Float32Array;
3923-
new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Float32Array;
3922+
new(array: ArrayLike<number>): Float32Array;
3923+
new(buffer: ArrayBufferLike, byteOffset?: number, length?: number): Float32Array;
39243924

39253925
/**
39263926
* The size in bytes of each element in the array.
@@ -4193,8 +4193,8 @@ interface Float64Array {
41934193
interface Float64ArrayConstructor {
41944194
readonly prototype: Float64Array;
41954195
new(length: number): Float64Array;
4196-
new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Float64Array;
4197-
new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Float64Array;
4196+
new(array: ArrayLike<number>): Float64Array;
4197+
new(buffer: ArrayBufferLike, byteOffset?: number, length?: number): Float64Array;
41984198

41994199
/**
42004200
* The size in bytes of each element in the array.

0 commit comments

Comments
 (0)