Updates Uint8ArrayConstructor to match MDN documentation. #38449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/Uint8Array ``` new Uint8Array(); // new in ES2017 new Uint8Array(length); new Uint8Array(typedArray); new Uint8Array(object); new Uint8Array(buffer [, byteOffset [, length]]); ``` While the previous constructors aren't significantly different from the new, it would prevent someone from doing `new Uint8Array(myBuffer, undefined, undefined)` since there was no overload that accepted undefined as a second parameter and buffer as first. Fixes microsoft#38446
|
Perhaps the same change should be applied to all other TypedArrays. |
Done. |
seishun
reviewed
May 10, 2020
|
OK, this looks good to me 👍 |
|
This also fixes this case: export class DataBlock extends Uint8Array {
constructor(sizeOrBuffer, ...restArgs) {
if (sizeOrBuffer instanceof ArrayBuffer) {
// fine.
super(sizeOrBuffer, ...restArgs);
} else {
Assert(typeof sizeOrBuffer === 'number');
super(sizeOrBuffer);
}
}
}Which previously failed for reasons similar to #14107. |
|
Because this splits up I think this is fairly rare, but it happens once in a large internal Microsoft codebase. |
sandersn
added a commit
that referenced
this pull request
Aug 3, 2020
PR #38449 changed the second overload of the constructor for Int8, Uint8, Int32, Uint32, Int16, Uint16, Float, Float64 -Array so that it no longer includes `ArrayBufferLike`. It's just `ArrayLike<number>`. This is fine except in the case that the caller provides exactly `ArrayLike<number> | ArrayBufferLike`. This PR adds ArrayBufferLike back so that the union is once again accepted. This avoids a breaking change, in particular in one Microsoft-internal codebase.
sandersn
added a commit
that referenced
this pull request
Aug 4, 2020
PR #38449 changed the second overload of the constructor for Int8, Uint8, Int32, Uint32, Int16, Uint16, Float, Float64 -Array so that it no longer includes `ArrayBufferLike`. It's just `ArrayLike<number>`. This is fine except in the case that the caller provides exactly `ArrayLike<number> | ArrayBufferLike`. This PR adds ArrayBufferLike back so that the union is once again accepted. This avoids a breaking change, in particular in one Microsoft-internal codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/Uint8Array
While the previous constructors aren't significantly different from the new, they would prevent someone from doing
new Uint8Array(myBuffer, undefined, undefined)since there was no overload that accepted undefined as a second parameter and buffer as first.Fixes #38446
Fixes #