Skip to content

ATA: node: module resolution#3191

Merged
jakebailey merged 4 commits intomicrosoft:v2from
Renegade334:ata-node-module-resolution
Jul 30, 2024
Merged

ATA: node: module resolution#3191
jakebailey merged 4 commits intomicrosoft:v2from
Renegade334:ata-node-module-resolution

Conversation

@Renegade334
Copy link
Contributor

  • There are certain modules that Node doesn't expose without the node: prefix, to avoid clashing with existing packages. These are now resolved.
  • Ensure that node: is only handled if it's a prefix (and not "dnode:ns" etc.)
  • Add inspector/promises to the module list.

@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Jul 29, 2024
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the changeset tweak to be more descriptive.

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3191.centralus.5.azurestaticapps.net

@jakebailey jakebailey merged commit 1d0af97 into microsoft:v2 Jul 30, 2024
@typescript-bot typescript-bot mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy-preview Enables automatic deployments to preview environments on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants