Fix missing typescript peer dependency package.json#3072
Merged
jakebailey merged 3 commits intomicrosoft:v2from Jun 5, 2024
Merged
Fix missing typescript peer dependency package.json#3072jakebailey merged 3 commits intomicrosoft:v2from
jakebailey merged 3 commits intomicrosoft:v2from
Conversation
Typescript is being used from src as a dependency but is only listed as a dev dependencies in the package.json. Package.json needs to be updated to include it as a peer dependency so package managers like pnpm can correctly resolve the dependency.
Member
|
This PR now requires a CLA since it now touches too many files; CLAs are normally not required for small changes like this was originally. Since the changeset is just procedure, I'll probably revert the CLA change and add the changeset manually elsewhere, unless you have the time to send the message listed above (which would be much easier). |
Contributor
Author
|
@microsoft-github-policy-service agree [company="Robinhood Markets"] |
Contributor
Author
|
@microsoft-github-policy-service agree company="Robinhood Markets" |
Member
|
Awesome, thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript is being used from src as a dependency but is only listed as a dev dependencies in the package.json. Package.json needs to be updated to include it as a peer dependency so package managers like pnpm can correctly resolve the dependency.