Skip to content

fix: ata return type#3002

Merged
jakebailey merged 3 commits intomicrosoft:v2from
antfu:fix/ata-return-type
Jun 4, 2024
Merged

fix: ata return type#3002
jakebailey merged 3 commits intomicrosoft:v2from
antfu:fix/ata-return-type

Conversation

@antfu
Copy link
Contributor

@antfu antfu commented Dec 17, 2023

It actually returns a Promise. Would be nice to provide that info so users could await for it to resolve.

return resolveDeps(initialSourceFile, 0).then(t => {
if (estimatedDownloaded > 0) {
config.delegate.finished?.(fsMap)
}
})

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will require a package release.

@jakebailey jakebailey closed this Jun 2, 2024
@jakebailey jakebailey reopened this Jun 2, 2024
@jakebailey jakebailey merged commit fd776c0 into microsoft:v2 Jun 4, 2024
@typescript-bot typescript-bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants