Skip to content

fix: jsx is undefined by default, not preserve or react #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2020
Merged

fix: jsx is undefined by default, not preserve or react #1102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
682e7ff
fix: `jsx` is undefined by default, not preserve or react
agilgur5 Sep 17, 2020
af8fcb1
Merge branch 'v2' into fix-jsx-default
Sep 18, 2020
13ba58a
Update Compiler Options.md
orta Sep 18, 2020
b8247bb
Update Compiler Options.md
orta Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/documentation/copy/en/project-config/Compiler Options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Option | Type | Default
`--inlineSources` | `boolean` | `false` | Emit the source alongside the sourcemaps within a single file; requires `--inlineSourceMap` or `--sourceMap` to be set.
`--init` | | | Initializes a TypeScript project and creates a `tsconfig.json` file.
`--isolatedModules` | `boolean` | `false` | Perform additional checks to ensure that separate compilation (such as with [`transpileModule`](https://github.com/Microsoft/TypeScript/wiki/Using-the-Compiler-API#a-simple-transform-function) or [@babel/plugin-transform-typescript](https://babeljs.io/docs/en/babel-plugin-transform-typescript)) would be safe.
`--jsx` | `string` | `"preserve"` | Support JSX in `.tsx` files: `"react"`, `"preserve"`, `"react-native"`. See [JSX](/docs/handbook/jsx.html).
`--jsx` | `string` | | Support JSX in `.tsx` files: `"react"`, `"preserve"`, `"react-native"`. See [JSX](/docs/handbook/jsx.html).
`--jsxFactory` | `string` | `"React.createElement"` | Specify the JSX factory function to use when targeting react JSX emit, e.g. `React.createElement` or `h`.
`--jsxFragmentFactory` | `string` | `"React.Fragment"` | Specify the JSX fragment factory function to use when targeting react JSX emit, e.g. `Fragment`.
`--keyofStringsOnly` | `boolean` | `false` | Resolve `keyof` to string valued property names only (no numbers or symbols).
Expand Down
3 changes: 2 additions & 1 deletion packages/tsconfig-reference/scripts/tsconfigRules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ export const defaultsForOptions = {
inlineSourceMap: "false",
inlineSources: "false",
isolatedModules: "false",
jsx: "undefined",
jsxFactory: "`React.createElement`",
keyofStringsOnly: "false",
listEmittedFiles: "false",
Expand Down Expand Up @@ -187,7 +188,7 @@ export const defaultsForOptions = {
};

export const allowedValues = {
jsx: ["`react` (default)", "`react-native`", "`preserve`"],
jsx: ["`react`", "`react-native`", "`preserve`"],
jsxFactory: ["Any identifier or dotted identifier"],
lib: ["See main content"],
target: [
Expand Down