fix: declaration is actually false by default #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2020
- previously said "True when TS", but that isn't accurate
- upon testing, it appears to be false by default
- an explicit `declaration: true` is required in `tsconfig.json` for
declaration files (`.d.ts`) to be output
- the Compiler Options docs also say it's default false too, so not sure
why it's different in the TSConfig Reference
- c.f. https://github.com/microsoft/TypeScript-Website/blob/46b960968f994968b237060065f651a368e5fc63/packages/documentation/copy/en/project-config/Compiler%20Options.md#L47
agilgur5
force-pushed
the
fix-declaration-default
branch
from
4384257 to
6271be8
Compare
This was referenced Sep 17, 2020
Contributor
|
Great - thanks, yeah, there is no way to automate them I'm afraid. The logic is pretty embedded in the compiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
previously said "True when TS", but that isn't accurate
declaration: trueis required intsconfig.jsonfordeclaration files (
.d.ts) to be outputthe Compiler Options docs also say it's default false too, so not sure
why it's different in the TSConfig Reference
TypeScript-Website/packages/documentation/copy/en/project-config/Compiler Options.md
Line 47 in 46b9609
Tags
This was discovered in jaredpalmer/tsdx#823 (comment)
Review Notes
Is there some way to auto-generate these from TS itself so that these are never incorrect/out-of-date?
I'm not sure what other discrepancies there may still be between the TSConfig Reference and Compiler Options docs