Skip to content

Conversation

@addreas
Copy link
Contributor

@addreas addreas commented May 6, 2020

Would be useful to see errors from the node process if it fails to start. For example when editing the typescript_tsdk setting the plugin might silently fail while the node process says that it was unable to find the specified file.

Would be useful to see errors from the node process if it fails to start. For example when editing the typescript_tsdk setting the plugin might silently fail while the node process says that it was unable to find the specified file.
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out locally and it seems to work fine, I couldn't crash the node process - but the code is pretty simple

@orta orta merged commit 498d74c into microsoft:master Jun 8, 2020
@orta
Copy link
Contributor

orta commented Jun 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants